Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: document Request.Host value in HTTP/2 #34640

Closed
FiloSottile opened this issue Oct 1, 2019 · 2 comments
Closed

net/http: document Request.Host value in HTTP/2 #34640

FiloSottile opened this issue Oct 1, 2019 · 2 comments
Labels
Documentation NeedsFix
Milestone
Go1.14

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Oct 1, 2019

HTTP/2 has :authority rather than Host, but I presume the Request.Host filed is filled in with that value for HTTP/2 requests. That should be documented.

/cc @bradfitz
@FiloSottile FiloSottile added this to the Go1.14 milestone Oct 1, 2019
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Member

@bradfitz bradfitz commented Oct 2, 2019

Seems like maybe over-documenting internal protocol details, but this is already kinda over-documented with HTTP/1 details, so... sure. Will send.
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Oct 2, 2019

Change https://golang.org/cl/198457 mentions this issue: net/http: document that Request.Host includes HTTP/2 :authority
@gopherbot gopherbot closed this in 0ba0ea1 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation NeedsFix
Projects
None yet
Milestone
  Go1.14
3 participants
@FiloSottile @bradfitz @gopherbot
You can’t perform that action at this time.