Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: (*LazyProc).Call does not keep arguments alive (anymore) [1.12 backport] #34641

Closed
gopherbot opened this issue Oct 1, 2019 · 4 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 1, 2019

@zx2c4 requested issue #34474 to be considered for backport to the next 1.12 minor release.

@gopherbot please backport this, because mis-compilations are dangerous and the fix appears to be a trivial single line fix.

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Oct 1, 2019

For release manager FYI: this is a regression introduced in Go 1.8. The fix is straight forward and safe, and I expect backports cleanly to Go 1.12, but just thought I'd make sure that complies with our backport policy.

@av86743
Copy link

@av86743 av86743 commented Oct 2, 2019

CL for #34474 is not finalized (indicated by Do-Not-Submit tag) - has to stage partial fix.

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Oct 8, 2019

By the backport policy, once this is fixed on a Go 1.13.x release, upgrading to that will be a valid workaround, so it does not qualify for backport to Go 1.12.x. (And anyway this is not a regression in Go 1.12.)

@FiloSottile FiloSottile closed this Oct 8, 2019
@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Oct 8, 2019

Whoops, I just neglected to mention "1.13" specifically to gobot. Sorry about that.

@katiehockman katiehockman modified the milestones: Go1.12.11, Go1.12.12 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.