Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
syscall: (*LazyProc).Call does not keep arguments alive (anymore) [1.13 backport] #34642
@FiloSottile I'm curious your thoughts here.
https://go-review.googlesource.com/c/go/+/198043 fixes direct calls to LazyProc.Call. It's minimal and safe and fixes the regression that was introduced in Go 1.8.
However, in #34684, I'm currently waiting for a decision on whether we support indirect call to LazyProc.Call too. If we do (which I don't think we handled correctly even back in Go 1.7), a somewhat more invasive fix will be necessary.
I'm somewhat inclined to proceed with CL 198043 as-is for now, and backport just that to Go 1.13. And then if we do decide to support indirect LazyProc.Call calls, it's okay to just fix that in Go 1.14 without backporting.