Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: infinite loop in LookupAddr() [1.12 backport] #34661

Closed
gopherbot opened this issue Oct 2, 2019 · 2 comments
Closed

net: infinite loop in LookupAddr() [1.12 backport] #34661

gopherbot opened this issue Oct 2, 2019 · 2 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone
Go1.12.12

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 2, 2019

@bradfitz requested issue #34660 to be considered for backport to the next 1.12 minor release.

@gopherbot, please backport to Go 1.12 and Go 1.13. This looks like a DoS vector.
@gopherbot gopherbot mentioned this issue Oct 2, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.11 milestone Oct 2, 2019
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 2, 2019

Change https://golang.org/cl/198497 mentions this issue: [release-branch.go1.12] net: avoid an infinite loop in LookupAddr
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 3, 2019

Closed by merging 273d946 to release-branch.go1.12.
@gopherbot gopherbot closed this Oct 3, 2019
gopherbot pushed a commit that referenced this issue Oct 3, 2019
@bradfitz
[release-branch.go1.12] net: avoid an infinite loop in LookupAddr
273d946 
If a request for a PTR record returned a response with a non-PTR
answer, goLookupPTR would loop forever.  Skipping non-PTR answers
guarantees progress through the DNS response.

Fixes #34661
Updates #34660

Change-Id: Ib5e5263243bc34b9e2f85aa2b913c9cd50dbcaa5
Reviewed-on: https://go-review.googlesource.com/c/go/+/198497
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@katiehockman katiehockman modified the milestones: Go1.12.11, Go1.12.12 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Milestone
Go1.12.12
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@andybons @gopherbot @katiehockman