Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: infinite loop in LookupAddr() [1.13 backport] #34662

Closed
gopherbot opened this issue Oct 2, 2019 · 5 comments
Closed

net: infinite loop in LookupAddr() [1.13 backport] #34662

gopherbot opened this issue Oct 2, 2019 · 5 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 2, 2019

@bradfitz requested issue #34660 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.12 and Go 1.13. This looks like a DoS vector.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Oct 2, 2019

Change https://golang.org/cl/198489 mentions this issue: [release-branch.go1.13] net: avoid an infinite loop in LookupAddr

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Oct 3, 2019

Closed by merging f262eed to release-branch.go1.13.

@gopherbot gopherbot closed this Oct 3, 2019
gopherbot pushed a commit that referenced this issue Oct 3, 2019
If a request for a PTR record returned a response with a non-PTR
answer, goLookupPTR would loop forever.  Skipping non-PTR answers
guarantees progress through the DNS response.

Fixes #34662
Updates #34660

Change-Id: I56f9d21e5342d07e7d843d253267e93a29707904
Reviewed-on: https://go-review.googlesource.com/c/go/+/198460
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit f0e940e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/198489
Reviewed-by: Michael Hendricks <michael@ndrix.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@mndrix

This comment has been minimized.

Copy link
Contributor

@mndrix mndrix commented Dec 5, 2019

Is this fix still planned for backport to 1.13? It was assigned to milestone 1.13.2 then 1.13.3 but hasn't moved in the last two minor releases. I'd still like to see it in 1.13 someday, but definitely in 1.14. Thanks.

@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented Dec 5, 2019

@mndrix, you're commenting on a closed bug. The comments above show it was merged.

And the Milestone says Go1.13.3 and it's in 1.13.3: https://go.googlesource.com/go/+log/refs/tags/go1.13.3

@mndrix

This comment has been minimized.

Copy link
Contributor

@mndrix mndrix commented Dec 5, 2019

Sorry for my confusion about the process. Now I understand. Thanks for the clarification @bradfitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.