Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort: Strings sort specifies increasing order (not lexicographic) #34666

Closed
JurisMajors opened this issue Oct 2, 2019 · 3 comments
Closed

sort: Strings sort specifies increasing order (not lexicographic) #34666

JurisMajors opened this issue Oct 2, 2019 · 3 comments

Comments

@JurisMajors
Copy link

@JurisMajors JurisMajors commented Oct 2, 2019

I believe 'increasing order' can be too ambiguous for official documentation. Since that could be interpreted as increasing in lengths of strings instead.
Strings sorts a slice of strings in increasing order.

I propose for it to state ...in lexicographical order instead. (e.g. Oracle Java docs do that)

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 2, 2019

Change https://golang.org/cl/198461 mentions this issue: sort: be more specific about string sorting order in docs

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 2, 2019

As I just noted on the CL, the sort package sorts using the same ordering as the language itself uses.

@andybons
Copy link
Member

@andybons andybons commented Oct 3, 2019

Closing as the discussion on the CL seems to have concluded that we should not change this.

@andybons andybons closed this Oct 3, 2019
@golang golang locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.