Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: DNS client relies on CNAME order #34677

Closed
iangudger opened this issue Oct 3, 2019 · 2 comments
Closed

net: DNS client relies on CNAME order #34677

iangudger opened this issue Oct 3, 2019 · 2 comments

Comments

@iangudger
Copy link
Contributor

@iangudger iangudger commented Oct 3, 2019

According to RFC 1034, section 3.6:

The order of RRs in a set is not significant, and need not be preserved by name servers, resolvers, or other parts of the DNS.

The current DNS client is relying on the RR order in order to determine the CNAME (source). I think this works because most DNS servers do serve CNAMES in a significant order.

/cc @mdempsky

@andybons andybons added this to the Unplanned milestone Oct 3, 2019
@mdempsky

This comment has been minimized.

Copy link
Member

@mdempsky mdempsky commented Oct 3, 2019

That code is grabbing the A/AAAA RRset owner name as a way to short circuit having to walk any CNAME chain. The logic is explained on lines 631–644.

@iangudger

This comment has been minimized.

Copy link
Contributor Author

@iangudger iangudger commented Oct 3, 2019

You're right.

@iangudger iangudger closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.