Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: `go mod download -json` is a lot slower with go1.13 [1.13 backport] #34679

Closed
gopherbot opened this issue Oct 3, 2019 · 2 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 3, 2019

@bcmills requested issue #34533 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13.2: this feature caused a significant performance regression for large repositories, and was newly introduced and fairly obscure (so is unlikely to have broad usage at this point).

The only likely users are other module proxy implementations; we're asking them explicitly if they care about this field in a golang-module-proxies thread.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Oct 4, 2019

Change https://golang.org/cl/199079 mentions this issue: [release-branch.go1.13] Revert "cmd/go: add a Latest field to the output of 'go mod download -json'"

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Oct 4, 2019

Closed by merging cf54026 to release-branch.go1.13.

@gopherbot gopherbot closed this Oct 4, 2019
gopherbot pushed a commit that referenced this issue Oct 4, 2019
…put of 'go mod download -json'"

This reverts CL 183841.

Updates #34533
Fixes #34679

Reason for revert: Introduced a significant performance regression for repos with many incompatible-version tags.

Change-Id: I75d7fd76e6e1a0902b114b00167b38439e0f8221
Reviewed-on: https://go-review.googlesource.com/c/go/+/198699
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 961837d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/199079
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.