Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: prevent large binaries from being checked in #34687

Closed
bradfitz opened this issue Oct 4, 2019 · 2 comments
Closed

x/build: prevent large binaries from being checked in #34687

bradfitz opened this issue Oct 4, 2019 · 2 comments
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 4, 2019

https://go-review.googlesource.com/c/tools/+/198743 reverts a large binary that was checked in by mistake in https://golang.org/cl/198441

We need some mechanism(s) to prevent this.

(I thought we already had a bug from previous times this happened, but I can't find it.)

Probably part of #18548 at least, but also in git-codereview wouldn't hurt (but it wouldn't be sufficient on its own, as not everybody uses git-codereview).

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Oct 4, 2019

Previously:

I think we should probably rewrite away this latest 19 MB binary too. I filed #34688 for that.

/cc @andybons @dmitshur @toothrot @stamblerre @ianthehat

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Oct 4, 2019

Oh, found it: #10658 already tracks this.

@bradfitz bradfitz closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.