Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: prevent large binaries from being checked in #34687

Closed
bradfitz opened this issue Oct 4, 2019 · 2 comments
Closed

x/build: prevent large binaries from being checked in #34687

bradfitz opened this issue Oct 4, 2019 · 2 comments
Labels
Builders FrozenDueToAge NeedsFix
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 4, 2019

https://go-review.googlesource.com/c/tools/+/198743 reverts a large binary that was checked in by mistake in https://golang.org/cl/198441

We need some mechanism(s) to prevent this.

(I thought we already had a bug from previous times this happened, but I can't find it.)

Probably part of #18548 at least, but also in git-codereview wouldn't hurt (but it wouldn't be sufficient on its own, as not everybody uses git-codereview).

@bradfitz bradfitz added the NeedsFix label Oct 4, 2019
@gopherbot gopherbot added this to the Unreleased milestone Oct 4, 2019
@gopherbot gopherbot added the Builders label Oct 4, 2019
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Oct 4, 2019

Previously:

I think we should probably rewrite away this latest 19 MB binary too. I filed #34688 for that.

/cc @andybons @dmitshur @toothrot @stamblerre @ianthehat

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Oct 4, 2019

Oh, found it: #10658 already tracks this.

@bradfitz bradfitz closed this as completed Oct 4, 2019
@golang golang locked and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders FrozenDueToAge NeedsFix
Projects
None yet
Development

No branches or pull requests

2 participants