Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: handle ldflag escapes in pkg-config output #34710

Open
raphi011 opened this issue Oct 5, 2019 · 2 comments

Comments

@raphi011
Copy link

commented Oct 5, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.9 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/raphi/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/raphi/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/golang"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/raphi/code/go/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build148444745=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Attempt to build a cgo binary with pkg-config containing ldflags with a whitespace.

What did you expect to see?

A successfull build.

What did you see instead?

go build github.com/ElektraInitiative/go-elektra/kdb: invalid flag in pkg-config --libs: elektra/build/lib

PR: #34709

Relates to

@onefy502

This comment has been minimized.

Copy link

commented Oct 6, 2019

ok

@katiehockman

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

@gopherbot gopherbot removed the NeedsDecision label Oct 7, 2019
@bcmills bcmills added this to the Unplanned milestone Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.