Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/{cmd/coordinator,app/appengine}: combine codebases #34744

Closed
dmitshur opened this issue Oct 7, 2019 · 45 comments
Closed

x/build/{cmd/coordinator,app/appengine}: combine codebases #34744

dmitshur opened this issue Oct 7, 2019 · 45 comments

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 7, 2019

We've discussed and agreed wanting to merge app/appengine into cmd/coordinator. The motivation is to have a single codebase, share more code, fewer separate deployments, and tests with more inclusive coverage.

I didn't find an existing issue, so making this one to track the task.

/cc @bradfitz @andybons @toothrot

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 7, 2019

I regret that I have but four emojis to give to this bug.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 8, 2019

Change https://golang.org/cl/199800 mentions this issue: app/appengine: don't exclude release-branch-only builders

gopherbot pushed a commit to golang/build that referenced this issue Oct 8, 2019
The filtering of builders in commitBuilders was too strict,
causing post-submit builders that are configured to run on
release-branches only to not get included in the list of
builders.

This change makes the following builders no longer skipped:

	darwin-amd64-10_10
	freebsd-386-10_3
	freebsd-386-10_4
	freebsd-386-11_1
	freebsd-amd64-10_3
	freebsd-amd64-10_4
	freebsd-amd64-11_1
	nacl-386
	nacl-amd64p32

We may need to adjust the build.golang.org UI after to avoid
including unhelpful columns, but this is a first step to get
nacl builders to run on release branches again.

Updates golang/go#34738
Updates golang/go#34744

Change-Id: Iaf2b93aedd5f44b48b9a63b57f12549fe50b1637
Reviewed-on: https://go-review.googlesource.com/c/build/+/199800
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 8, 2019

Change https://golang.org/cl/199878 mentions this issue: app/appengine: hide release-branch-only builders when viewing master branch

gopherbot pushed a commit to golang/build that referenced this issue Oct 8, 2019
…branch

This is a follow-up to CL 199800. That change started to consider more
builders as active to allow release-branch-only builders to run.

However, it also made those builders show up as new empty columns when
viewing builds for the master branch. There are quite a few old FreeBSD
builders that only run on release-branch.go1.12, and it's too disruptive
to have them appear everywhere. So, hide them when viewing the master
branch of Go repo in the UI.

There can be more UI improvements to be made, and this can become too
much of a whack-a-mole to address them one by one. The scope of this CL
is to fix the most disruptive high priority problem for now. Further
improvements will happen later, with merging of app/appengine and
cmd/coordinator codebases in mind.

Updates golang/go#34738
Updates golang/go#34744

Change-Id: I3df75f8b2bbd5f6fe8097c181ee8a1b1b4354dc9
Reviewed-on: https://go-review.googlesource.com/c/build/+/199878
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
The filtering of builders in commitBuilders was too strict,
causing post-submit builders that are configured to run on
release-branches only to not get included in the list of
builders.

This change makes the following builders no longer skipped:

	darwin-amd64-10_10
	freebsd-386-10_3
	freebsd-386-10_4
	freebsd-386-11_1
	freebsd-amd64-10_3
	freebsd-amd64-10_4
	freebsd-amd64-11_1
	nacl-386
	nacl-amd64p32

We may need to adjust the build.golang.org UI after to avoid
including unhelpful columns, but this is a first step to get
nacl builders to run on release branches again.

Updates golang/go#34738
Updates golang/go#34744

Change-Id: Iaf2b93aedd5f44b48b9a63b57f12549fe50b1637
Reviewed-on: https://go-review.googlesource.com/c/build/+/199800
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
…branch

This is a follow-up to CL 199800. That change started to consider more
builders as active to allow release-branch-only builders to run.

However, it also made those builders show up as new empty columns when
viewing builds for the master branch. There are quite a few old FreeBSD
builders that only run on release-branch.go1.12, and it's too disruptive
to have them appear everywhere. So, hide them when viewing the master
branch of Go repo in the UI.

There can be more UI improvements to be made, and this can become too
much of a whack-a-mole to address them one by one. The scope of this CL
is to fix the most disruptive high priority problem for now. Further
improvements will happen later, with merging of app/appengine and
cmd/coordinator codebases in mind.

Updates golang/go#34738
Updates golang/go#34744

Change-Id: I3df75f8b2bbd5f6fe8097c181ee8a1b1b4354dc9
Reviewed-on: https://go-review.googlesource.com/c/build/+/199878
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 21, 2019

Change https://golang.org/cl/208319 mentions this issue: app/appengine: remove ancient performance/benchmarking code

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 21, 2019

Change https://golang.org/cl/208320 mentions this issue: app/appengine, cmd/genbuilderkey: move key gen from App Engine to new tool

gopherbot pushed a commit to golang/build that referenced this issue Nov 21, 2019
This was the performance/benchmark code from ~three generations ago.

It's unused and unmaintained. It broke when we moved from mercurial to
git, IIRC.

I'm attempting to modernize this code (for golang/go#34744) but it'd
be easier if there's less code to deal with.

Updates golang/go#34744

Change-Id: Ib4999830b05df9ffad9b46964022325404350b47
Reviewed-on: https://go-review.googlesource.com/c/build/+/208319
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Nov 21, 2019
… tool

This moves the /key handler to generate build keys to a standalone
tool. The old way has been largely broken for years (when using the
build.golang.org domain) due to internal App Engine changes. We have
to access it via https://build-dot-golang-org.appspot.com/key instead
to get authenticated.

Also, the App Engine go112 runtime doesn't support authenticated
handlers, so more reason to move off App Engine.

This CL is part of a series to move off the the build.golang.org App
Engine app that mirrors the git history into Datastore Entities, which
is full of complication and bugs.

These early steps are about removing a bunch of code from the App
Engine app so the important bits are easy to see and refactor.

Updates golang/go#34744

Change-Id: Iaf8e2bf458b5fea45bf05026d8a6eaf0ead88ec2
Reviewed-on: https://go-review.googlesource.com/c/build/+/208320
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 21, 2019

Change https://golang.org/cl/208322 mentions this issue: app/appengine: delete old "broke the build" code

gopherbot pushed a commit to golang/build that referenced this issue Nov 21, 2019
It hasn't worked in years.

This is part of a series of CLs to clean up the build.golang.org App
Engine app in prep for it to be modernized, refactored, and replaced.

Updates golang/go#34744
Updates golang/go#12509

Change-Id: I9f8445046961ccbe97f7b9c85c0772393bf7d547
Reviewed-on: https://go-review.googlesource.com/c/build/+/208322
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 21, 2019

Change https://golang.org/cl/208324 mentions this issue: app/appengine: delete more dead code

gopherbot pushed a commit to golang/build that referenced this issue Nov 21, 2019
This is part of a series of CLs to clean up the build.golang.org App
Engine app in prep for it to be modernized, refactored, and replaced,
starting with deleting dead code.

Updates golang/go#34744

Change-Id: I6cddbb44a63597a308f1d4399d21e5b70a8d83bf
Reviewed-on: https://go-review.googlesource.com/c/build/+/208324
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 22, 2019

Change https://golang.org/cl/208397 mentions this issue: app/appengine: delete yet more dead code

gopherbot pushed a commit to golang/build that referenced this issue Nov 22, 2019
This is part of a series of CLs to clean up the build.golang.org App
Engine app in prep for it to be modernized, refactored, and replaced,
starting with deleting dead code.

Some of this was missed in CL 208319.

Updates golang/go#34744

Change-Id: I35adf4296b849dabed9d974e7eb58eeedc7d4293
Reviewed-on: https://go-review.googlesource.com/c/build/+/208397
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2019

Change https://golang.org/cl/208678 mentions this issue: app/appengine: remove unused tagHandler, document others, remove auth from init

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 25, 2019

Change https://golang.org/cl/208697 mentions this issue: app, gitmirror, maintner: use maintner for dashboard, not datastore

gopherbot pushed a commit to golang/build that referenced this issue Nov 25, 2019
… from init

tagHandler isn't used by anything. Delete. Less code to update.

And document who calls the other handlers.

Also, remove the auth requirement from the /init handler. It's
harmless to call without auth, and the login restriction went away
with the Go 1.12+ runtime anyway, so deleting it gets us closer to
being able to use the Go 1.12/Go 1.13 runtimes. (The plan is to delete
most the code, port the small remaining bit to the cloud.google.com/go
libraries so we can update to Go 1.12/Go 1.13+, and then at that
point, since the cloud.google.com/go code will run anywhere, we can
just run it in the same process as the coordinator.)

Updates golang/go#34744

Change-Id: I929c70945a3e9e27b38b1d5899c7860470361927
Reviewed-on: https://go-review.googlesource.com/c/build/+/208678
Reviewed-by: Bryan C. Mills <bcmills@google.com>
gopherbot pushed a commit to golang/build that referenced this issue Dec 6, 2019
Historically, the build.golang.org was the entire build system, and it
maintained a parallel copy of that git history in its datastore. It
was always buggy and incomplete and things like force pushes were
scary because the datastore mirror could get out of sync. It was also
a lot of code to support that sync.

This changes build.golang.org to instead get the git history from
maintnerd, and then we can remove all the HTTP handlers around
updating it, and can remove all the gitmirror code to call it to
maintain it.

Now build.golang.org only keeps build results, keyed on the commit
hash. It's much less code, but is still an App Engine app for now.
(but it's getting small enough, that porting it to
cloud.google.com/go/datastore is looking very simple)

This also adds a new "repos" package to unify the configuration of the
various Go repos. There were incomplete & redundant copies all over
the place.

Updates golang/go#34744
Fixes golang/go#35828
Fixes golang/go#31236 (New branch=mixed support adds this when desired)
Fixes golang/go#35944

Change-Id: Ifb39417287df3dea052ba8510566d80b4bc75d51
Reviewed-on: https://go-review.googlesource.com/c/build/+/208697
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 9, 2019

This is getting pretty close now.

Here's a suggested roadmap for finishing this:

  • add an HTTP handler to the coordinator for removing build results. Currently there are only two things remaining that POST to the dashboard (the build.golang.org App Engine app): the coordinator itself, and x/build/cmd/retrybuilds. If we want to get to the coordinator knowing the world state (including keeping the work list in memory), we can't have retrybuilds reaching behind its back and writing to the datastore directly. So we should for now add a proxy handler to the coordinator that just proxies the /clear-results path to build.golang.org. Then change retrybuilds to use the farmer.golang.org hostname instead of build.golang.org.

  • change the coordinator's findWork to not hit the dashboard but instead do the maintnerd GetDashboard API call itself. This'll need to start doing datastore Get calls (to either golang-org's GCP project w/ new service account, or migrate the data, which seems unnecessarily painful)

  • modify the coordinator's /clear-results handler to do the datastore deletion itself. (And it can then also immediately start the replacement work, to rebuild whatever was cleared, without waiting for findWork to run)

  • add a JSON handler to the coordinator that lists all the active post-submit builds

  • drop the dashboard memcache code for buildingURLs (the blue gophers that render on the dashboard for in-progress builds) and instead hit the new JSON endpoint to figure out what's in progress. This then removes all memcache usage in the dashboard, which isn't (as easily) available in the new App Engine Go 1.12+ runtimes.

  • update app/appengine from the App Engine datastore package to the Cloud (cloud.google.com/go/datastore) package. This is required to update to the App Engine Go 1.12 runtime. Do that to verify it all works.

  • move the app/appengine UI code to a shared spot and make the coordinator also capable of running that handler. Now that it's using cloud.google.com/go/datastore, this should be trivial. Make an HTTP mux that routes to the dashboard UI handler based on Hostname. Say, if `hostname == "build.golang.org" || hostname == "farmer-ui-test.golang.org".

  • create DNS record farmer-ui-test.golang.org to test that it works.

  • change the build.golang.org DNS record.

  • delete the App Engine app

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 11, 2019

Change https://golang.org/cl/210838 mentions this issue: app/appengine, cmd/coordinator: fetch active builds from coordinator, avoid memcache

gopherbot pushed a commit to golang/build that referenced this issue Dec 11, 2019
… avoid memcache

This implements bullets 4 and 5 from the plan to unify the dashboard &
coordinator:
golang/go#34744 (comment)

Previously the coordinator would POST to the dashboard regularly, for
each active build, to say "I'm still working on this build! Write that
to memcache!". And then if somebody loaded https://build.golang.org/
it would do a big memcache multi-get to populate the little blue
gopher links to their status pages on the coordinator.

This instead turns it around. We no longer POST from the coordinator
to the dashboard, and we no longer use any memcache (which also means
migrating to the App Engine Go 1.13 runtime is easier, which drops
the built-in memcache support). Instead, the dashboard now does a GET
to the coordinator to get the list of active builds.

This also adds test coverage, which we didn't have before.

Updates golang/go#34744

Change-Id: I97a486ec362a7a00d29076c81a88d6417b138c1b
Reviewed-on: https://go-review.googlesource.com/c/build/+/210838
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 11, 2019

Change https://golang.org/cl/210977 mentions this issue: app/appengine: migrate from App Engine to Cloud APIs, move to Go 1.13

gopherbot pushed a commit to golang/build that referenced this issue Jul 30, 2021
This script was used on two cron-part.yaml files
which are gone as of CL 46832 and CL 208397.

For golang/go#34744.

Change-Id: If8dd34391e57e011909d22142a4f6c979b8bb51f
Reviewed-on: https://go-review.googlesource.com/c/build/+/336389
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Jul 30, 2021
Add a copy of x/build/app/appengine while making minimal modifications
to make it a package that coordinator can import instead of a command.

It'll be integrated into cmd/coordinator in the next CL.
The CL following that will delete the app/appengine code.

For golang/go#34744.

Change-Id: I6ee6e9547144c56fc04147a17f46c83d1bb37933
Reviewed-on: https://go-review.googlesource.com/c/build/+/336790
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Jul 30, 2021
Serve a copy of the build dashboard (including its remaining HTTP API
endpoints) at build.golang.org directly from coordinator. This makes
it so that both the dashboard and the coordinator are a single process,
so it's easier to make changes and deploy (only one component instead
of two). It also makes it possible for the two components to communicate
in simpler ways than via APIs.

Also serve it on farmer-ui-test endpoints for gradual rollout and
testing purposes. These will go away after the transition is done.

For golang/go#34744.

Change-Id: Iafa3a2ca2359419ea00501b6b0082ab92bcfb5c2
Reviewed-on: https://go-review.googlesource.com/c/build/+/336791
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Jul 30, 2021

The stack up to CL 336791 has been submitted and deployed. The new coordinator-powered dashboard is being served at https://farmer-ui-test.golang.org.

I'm not spotting any problems in my testing so far, so the next step will be to flip the DNS of build.golang.org over to be served by cmd/coordinator as well. If all goes well, the appengine code base can then be deleted (that's CL 336792).

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 6, 2021

Change https://golang.org/cl/340431 mentions this issue: cmd/coordinator/internal/legacydash: set Content-Type in htmlView

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 6, 2021

Change https://golang.org/cl/340116 mentions this issue: cmd/coordinator: unify headers visually

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 6, 2021

Change https://golang.org/cl/340433 mentions this issue: cmd/coordinator: remove support for farmer-ui-test

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 6, 2021

Change https://golang.org/cl/340432 mentions this issue: cmd/coordinator: expose multiple domains during local development

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 6, 2021

Change https://golang.org/cl/340435 mentions this issue: cmd/coordinator: link "ok" results to build logs

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 6, 2021

Change https://golang.org/cl/340434 mentions this issue: cmd/coordination: update documentation

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 6, 2021

Change https://golang.org/cl/340589 mentions this issue: buildenv: temporarily use farmer-ui-test.golang.org as dashboard URL

gopherbot pushed a commit to golang/build that referenced this issue Aug 6, 2021
The build.golang.org service is undergoing a transition as part of
https://golang.org/issue/34744#issuecomment-890076711. It's taking
some time for the DNS change to propagate and HTTPS certificate to
be acquired. During this time, use farmer-ui-test.golang.org as the
dashboard URL, since it's currently used by cmd/coordinator to find
post-submit work and report post-submit build results.

For golang/go#34744.

Change-Id: I7ca99dc75afa2960f831248110c9e5053ee95f99
Reviewed-on: https://go-review.googlesource.com/c/build/+/340589
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 9, 2021
In htmlView.ServeDashboard, we know very well that the content being
served is HTML. Set the Content-Type header explicitly to indicate
that, to avoid clients from having to do needless computationally-
expensive guessing. (This will help the next change, where we need
to know the Content-Type to be able to rewrite URLs in said HTML.)

Also improve and inline the logErr helper that was undocumented
and used in only 3 places. It's more readable to use http.Error.

For golang/go#34744.

Change-Id: I783d6559274bd2b9eeb7efcfe9464122cf4a9a68
Reviewed-on: https://go-review.googlesource.com/c/build/+/340431
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Aug 9, 2021

Flipping the DNS has been done (in a somewhat bumpy way, see #47580, but it's resolved now). https://build.golang.org is now served by coordinator!

Coordinator needed additional permissions to be able to write build results, which has also been resolved by now.

The stack up to CL 340434 is mostly reviewed but awaiting a few more reviews. We should be able to proceed with it landing it, making sure everything still works, and then this issue can be considered resolved.

gopherbot pushed a commit to golang/build that referenced this issue Aug 10, 2021
The coordinator now serves both farmer.golang.org and build.golang.org.
It has been possible to access the build dashboard page during local
development either by modifying source code, or /etc/hosts, but this
is not convenient.

Instead, use a hostPathHandler in local development mode which maps:

	https://localhost:8119/farmer.golang.org/ → farmer.golang.org pages
	https://localhost:8119/build.golang.org/  → build.golang.org pages

Which is very convenient, and will become even better after the next CL
unifies the header across the pages.

This is based on the approach in golang.org/x/website/cmd/golangorg for
serving multiple domains on localhost, implemented in CL 328013 by Russ.

For golang/go#34744.

Change-Id: Icd90c776db0898a797455cbb0dfb0fc038d050d2
Reviewed-on: https://go-review.googlesource.com/c/build/+/340432
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
gopherbot pushed a commit to golang/build that referenced this issue Aug 10, 2021
A header is displayed on 3 pages:

	• farmer.golang.org          - the coordinator status page
	• farmer.golang.org/builders - list of builders
	• build.golang.org           - the build dashboard page
	                               (now served by coordinator)

They look slightly different visually. There's also no good way
to navigate from the dashboard back to coordinator status page.

This change makes them all look the same, making it easier to
refactor them in the future, and improves ability to navigate.

Apply the same change to the work-in-progress dashboard V2 page,
to keep it in sync.

For golang/go#34744.
Fixes golang/go#47477.

Change-Id: Ib17d3e2955fa42afbb4bccb249ec5a8786ceab6e
Reviewed-on: https://go-review.googlesource.com/c/build/+/340116
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 10, 2021
…ui-test

The farmer-ui-test domain was added to help with a gradual rollout of
the dashboard unification. It was also used when the build.golang.org
DNS was still propagating and not yet fully available. All that's done
by now, so these aren't needed and can be removed.

Switch to using the final post-unification URL, build.golang.org in
production and build-staging.golang.org in the staging environment.

Simplify the handler registration by using http.ServeMux's host prefix
support.

For golang/go#34744.
Updates golang/go#47580.

Change-Id: I03c0529bd948e812ccf5c5aa312de247d174ad0a
Reviewed-on: https://go-review.googlesource.com/c/build/+/340433
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
gopherbot pushed a commit to golang/build that referenced this issue Aug 10, 2021
The appengine command is no longer needed since
the coordinator is serving the build dashboard.

The key package is now unused.

For golang/go#34744.

Change-Id: I74218bac6b7457434975d13842e59e150fc078be
Reviewed-on: https://go-review.googlesource.com/c/build/+/336792
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 10, 2021
Update documentation to reflect changes from the dashboard unification.

For golang/go#34744.

Change-Id: Ifb61207dd61496df0e8e9c96fd05730399e3a4b8
Reviewed-on: https://go-review.googlesource.com/c/build/+/340434
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 10, 2021
Every now and then, it's highly desirable to be able to view build
logs for a build even if it was successful. Those logs are kept as
of CL 198197, but they just haven't been linked. At long last, add
those links to the build dashboard(s)! 🎉

Keep the visual style of "ok" cells the same, aside that the mouse
cursor becomes a hand with an index finger, rather than a text caret.
This means this feature isn't very discoverable, but we can address
that in the future. (I've experimented with giving the "ok" links
an underline, but even a faint underline quickly leads to a large
amount of overwhelming visual noise when there are hundreds of "ok"
cells on many pages.)

Apply the same change to the work-in-progress dashboard V2 page,
to keep it in sync. (There are additional CSS changes to make it
look more consistent with the current build.golang.org dashboard.)

For golang/go#34119.
Updates golang/go#34744.

Change-Id: I27530e4103bbfd10e8cf09ae1a1cfce06c9bd748
Reviewed-on: https://go-review.googlesource.com/c/build/+/340435
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Aug 10, 2021

This is now live and submitted to x/build. Notably:

CL 340433 reconfigured coordinator to use the build.golang.org URL as the dashboard.
CL 336792 deleted the old app/appengine codebase.
CL 340434 updated documentation to reflect the new state.

CL 340435 was a cherry on top, bringing a small enhancement to the now-served-by-coordinator build dashboard.

Filed #47630 for some trivial clean up that can happen (after waiting a bit).
Other than that, woohoo, this is done! 🎉 🚀

@dmitshur dmitshur closed this Aug 10, 2021
Go Release Team automation moved this from In Progress to Done Aug 10, 2021
@zikaeroh

This comment has been hidden.

@dmitshur

This comment has been hidden.

@zikaeroh

This comment has been hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants