Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add macOS Catalina builder (darwin/amd64 only) #34748

Closed
bradfitz opened this issue Oct 7, 2019 · 9 comments
Closed

x/build: add macOS Catalina builder (darwin/amd64 only) #34748

bradfitz opened this issue Oct 7, 2019 · 9 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 7, 2019

macOS Catalina is out.

We need a builder. Probably before Go 1.14 comes out.

/cc @toothrot @andybons @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2019
@gopherbot gopherbot added the Builders label Oct 7, 2019
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 7, 2019

Just a 64-bit one, right? macOS Catalina does not support running 32-bit apps.

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Oct 7, 2019

Can't test what doesn't exist.

Maybe it's almost time to remove the darwin/386 port. Filed #34749.

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Nov 5, 2019

We continue to hit Catalina bugs (most recently #35247). We need to get this builder up before the release.

/cc @cagedmantis too.

@bradfitz bradfitz modified the milestones: Unreleased, Go1.14 Nov 5, 2019
@cagedmantis cagedmantis self-assigned this Nov 5, 2019
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Nov 11, 2019

I've confirmed with MacStadium that we need to upgrade our version of vSphere in order to run Catalina builders. I'm investigating what the upgrade process would entail.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 18, 2019

Change https://golang.org/cl/207737 mentions this issue: cmd/makemac: add macOS 10.15 Catalina as an available builder version

gopherbot pushed a commit to golang/build that referenced this issue Nov 18, 2019
Makemac has been unable to create a macOS 10.15 Catalina builder. The
Catalina image is now available for creation.

Updates golang/go#34748

Change-Id: Ibc6a5f64be4de5d2eb4a89002e29944c77b6627c
Reviewed-on: https://go-review.googlesource.com/c/build/+/207737
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 19, 2019

Change https://golang.org/cl/207937 mentions this issue: dashboard, cmd/makemac: add macOS 10.15 Catalina builder

gopherbot pushed a commit to golang/build that referenced this issue Nov 21, 2019
Added the macOS 10.15 Catalina builder to the dashboard. Catalina builders should
use the Mojave guestid in vSphere 6.7 update 3 because the Catalina guestid is not
available in this version of vSphere. A Catalina builder will run on this version
of vSphere with the Mojave guestid. Modified the expected number of vm instances
running on Macstadium due to the addition of macOS 10.15 builders.

Updates golang/go#34748

Change-Id: If14f6e088afc05dd1783460f21907e9345e3c338
Reviewed-on: https://go-review.googlesource.com/c/build/+/207937
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Nov 21, 2019

The macOS 10.15 Catalina builder has been added.

@haithngn
Copy link

@haithngn haithngn commented Aug 2, 2020

@cagedmantis
unfortunately #40532 this might happen again

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Aug 13, 2020

@haithngn There was a follow up question on the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.