Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestServerSetKeepAlivesEnabledClosesConns is flaky #34792

Open
bcmills opened this issue Oct 9, 2019 · 5 comments
Open

net/http: TestServerSetKeepAlivesEnabledClosesConns is flaky #34792

bcmills opened this issue Oct 9, 2019 · 5 comments
Labels
NeedsInvestigation
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 9, 2019

Seen on release-branch.go1.13, but I'm not aware of any changes so far in 1.14 that would have addressed it.

On the aix-ppc64 builder (https://build.golang.org/log/2f6288cba5f841204de6c1761093e54fa59e3839):

--- FAIL: TestServerSetKeepAlivesEnabledClosesConns (2.15s)
    serve_test.go:5536: idle count after SetKeepAlivesEnabled called = 1; want 0
FAIL
FAIL	net/http	3.725s

See previously #17754 (CC @mdempsky @bradfitz)

@bcmills bcmills added the NeedsInvestigation label Oct 9, 2019
@bcmills bcmills added this to the Go1.14 milestone Oct 9, 2019
@rsc rsc removed this from the Go1.14 milestone Oct 9, 2019
@rsc rsc added this to the Backlog milestone Oct 9, 2019
@bcmills
Copy link
Member Author

@bcmills bcmills commented Dec 9, 2019

A couple of different failure modes. aix and plan9 tend to be

    serve_test.go:5541: idle count after SetKeepAlivesEnabled called = 1; want 0

while the others tend to be

    serve_test.go:5520: expected first two requests on same connection

It's not obvious to me whether those two failure modes share an underlying cause.

2019-12-06T00:57:11-7673884/aix-ppc64
2019-12-04T19:27:51-98e7270/plan9-arm
2019-11-23T00:06:41-f29e53d/aix-ppc64
2019-11-13T21:24:35-718f553/plan9-arm
2019-11-11T19:56:33-0e312f2/aix-ppc64
2019-11-11T17:59:46-6375fe4/freebsd-amd64-race
2019-11-05T00:00:43-ea0b4e7/plan9-arm
2019-10-17T21:10:22-f922645/openbsd-386-62
2019-10-10T11:31:54-900ebcf/plan9-arm
2019-09-03T19:33:04-d2f958d/plan9-arm
2019-08-29T15:21:31-35ac194/plan9-arm
2019-08-28T16:28:19-8419844/illumos-amd64-joyent
2019-08-08T20:38:47-1dc0110/aix-ppc64

@bcmills bcmills changed the title net/http: TestServerSetKeepAlivesEnabledClosesConns flake on aix-ppc64 builder net/http: TestServerSetKeepAlivesEnabledClosesConns is flaky Dec 9, 2019
@bcmills
Copy link
Member Author

@bcmills bcmills commented Jan 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

2 participants