Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: newlines inconsistently preserved in go.mod rewriting [1.13 backport] #34800

Closed
gopherbot opened this issue Oct 9, 2019 · 6 comments

Comments

@gopherbot
Copy link

commented Oct 9, 2019

@zx2c4 requested issue #33779 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport this to 1.13, because it's a regression from the 1. 12, and it causes dirty files in version control and disturbs other automated systems that don't appreciate stable file contents flopping around.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

Change https://golang.org/cl/200118 mentions this issue: cmd/go/internal/modfile: remove preceding empty lines when setting require

@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

Change https://golang.org/cl/200118 mentions this issue: [release-branch.go1.13] cmd/go/internal/modfile: remove preceding empty lines when setting require

@av86743

This comment has been minimized.

Copy link

commented Oct 10, 2019

Isn't it in fact ...: removeall blanklines from require section?

@bcmills

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

I don't think we should backport this. It may be a regression, but it's cosmetic at best — and as far as I can tell has a simple workaround (namely, don't add newlines in a require block).

CC @jayconrod

@zx2c4

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

@bcmills That's fine with me. Feel free to close this (if jay doesn't disagree).

@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@toothrot

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2019

Closing this issue, as it doesn't seem to meet our bar of "serious problems with no workaround". Please comment if I am mistaken.

@toothrot toothrot closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.