Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: nil pointer dereference crash when building with an Android NDK toolchain [1.13 backport] #34825

Closed
gopherbot opened this issue Oct 10, 2019 · 5 comments
Closed

cmd/link: nil pointer dereference crash when building with an Android NDK toolchain [1.13 backport] #34825

gopherbot opened this issue Oct 10, 2019 · 5 comments
Assignees
@thanm
Labels
CherryPickApproved FrozenDueToAge
Milestone
Go1.13.5

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 10, 2019

@thanm requested issue #34788 to be considered for backport to the next 1.13 minor release.

@gopherbot Please open a backport to 1.13.
@gopherbot gopherbot mentioned this issue Oct 10, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.2 milestone Oct 10, 2019
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@toothrot toothrot modified the milestones: Go1.13.3, Go1.13.4 Oct 17, 2019
@toothrot
Copy link
Contributor

@toothrot toothrot commented Oct 17, 2019

Bumping, as there is no fix merged for master yet.
@thanm
Copy link
Member

@thanm thanm commented Oct 17, 2019

Apologies, I have been bogged down with other issues. Hope to pick this back up soon.
@toothrot
Copy link
Contributor

@toothrot toothrot commented Oct 17, 2019

No need to apologize! I just wanted to leave a comment so it was not a surprise.
@thanm thanm self-assigned this Oct 29, 2019
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 29, 2019

Change https://golang.org/cl/204100 mentions this issue: [release-branch.go1.13] cmd/compile: fix spurious R_TLE_LE reloc on android/386
@andybons andybons modified the milestones: Go1.13.4, Go1.13.5 Oct 31, 2019
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Dec 4, 2019

Closed by merging f238d3b to release-branch.go1.13.
@gopherbot gopherbot closed this Dec 4, 2019
gopherbot pushed a commit that referenced this issue Dec 4, 2019
@thanm @cagedmantis
[release-branch.go1.13] cmd/compile: fix spurious R_TLE_LE reloc on a…
f238d3b 
…ndroid/386

When compiling for GOARCH=386 GOOS=android, the compiler was attaching
R_TLS_LE relocations inappropriately -- as of Go 1.13 the TLS access
recipe for Android refers to a runtime symbol and no longer needs this
type of relocation (which was causing a crash when the linker tried to
process it).

Fixes #34825.

Change-Id: Ida01875011b524586597b1f7e273aa14e11815d6
Reviewed-on: https://go-review.googlesource.com/c/go/+/200337
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Elias Naur <mail@eliasnaur.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/204100
@golang golang locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thanm thanm

Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Milestone
Go1.13.5
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@toothrot @cagedmantis @andybons @gopherbot @thanm @katiehockman
You can’t perform that action at this time.