Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Client.Do() panics when URL includes HTTP basic auth [1.12 backport] #34881

Closed
gopherbot opened this issue Oct 13, 2019 · 5 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 13, 2019

@odeke-em requested issue #34878 to be considered for backport to the next 1.12 minor release.

Thank you for the report @bradleyjkemp!

This a new panic in Go1.13 that stems from the fact that invoking Header.Clone() when Header is nil returns a nil map as we implemented in CL https://go-review.googlesource.com/c/go/+/188022 to solve the inconsistency behavior of Clone as per #33141, but we didn't go through all the call sites to check that the map was nil before assignment.

The code posted up used to work in Go1.12 and before, now fails in Go1.13.
/cc @andybons @bradfitz @FiloSottile for awareness

@gopherbot please backport this issue to Go1.13.

@odeke-em

This comment has been minimized.

Copy link
Member

@odeke-em odeke-em commented Oct 13, 2019

Odd, in #34878 (comment) I had typed @gopherbot please backport this issue to Go1.13. and it opened a backport to Go1.12 so I'll manually close this one.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Oct 13, 2019

Backport issue(s) opened: #34883 (for 1.12), #34884 (for 1.13).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@av86743

This comment has been minimized.

Copy link

@av86743 av86743 commented Oct 13, 2019

Notice that #34883 is now closed, too.

@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented Oct 14, 2019

@odeke-em, you might need a space after "Go". File a bug to fix the bot?

@odeke-em

This comment has been minimized.

Copy link
Member

@odeke-em odeke-em commented Oct 14, 2019

Notice that #34883 is now closed, too.

@av86743 yes I intentionally closed it as it was opened by the bot seeing itself being summoned.

@odeke-em, you might need a space after "Go". File a bug to fix the bot?

TIL, thank you @bradfitz, I've opened #34887.

@katiehockman katiehockman modified the milestones: Go1.12.11, Go1.12.12 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.