net/http: Client.Do() panics when URL includes HTTP basic auth [1.13 backport] #34882
Milestone
Comments
Change https://golang.org/cl/201040 mentions this issue: |
Closed by merging 2018d43 to release-branch.go1.13. |
gopherbot
pushed a commit
that referenced
this issue
Oct 14, 2019
…t.Header For Go 1.13 we introduced Header.Clone and it returns nil if a nil Header is cloned. Unfortunately, though, this exported Header.Clone nil behavior differed from the old Go 1.12 and earlier internal header clone behavior which always returned non-nil Headers. This CL fixes the places where that distinction mattered. Fixes #34882 Change-Id: Id19dea2272948c8dd10883b18ea7f7b8b33ea8eb Reviewed-on: https://go-review.googlesource.com/c/go/+/200977 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> (cherry picked from commit 9969c72) Reviewed-on: https://go-review.googlesource.com/c/go/+/201040
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@odeke-em requested issue #34878 to be considered for backport to the next 1.13 minor release.
The text was updated successfully, but these errors were encountered: