Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: semantically recognize Go<VERSION> in backport messages instead of opening backports for all #34887

Open
odeke-em opened this issue Oct 14, 2019 · 3 comments

Comments

@odeke-em
Copy link
Member

@odeke-em odeke-em commented Oct 14, 2019

Coming here from issue #34878 (comment) in which I used <BOT> please backport this issue to Go1.13. but the bot opened up issues to Go1.12 and Go1.13 and then afterwards I commented to try to close other issues which then caused another set of backporting issues to be opened #34883 #34884.

This issue is to request that we understand not only 1.13 but also Go1.13 which I typed because I wasn't fully aware of the syntax. Thanks @bradfitz for encouraging me to file a bug about this in #34881 (comment).

@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented Oct 14, 2019

The current code always does past two releases, unless you want it to do three, I guess:

                majorReleases, err := b.getMajorReleases(ctx)
                if err != nil {
                        return err
                }
                var selectedReleases []string
                for _, r := range majorReleases {
                        if strings.Contains(backportComment.Body, r) {
                                selectedReleases = append(selectedReleases, r)
                        }
                }
                if len(selectedReleases) == 0 {
                        // Only backport to major releases unless explicitly
                        // asked to backport to the upcoming release.
                        selectedReleases = majorReleases[:len(majorReleases)-1]
                }
@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented Oct 14, 2019

So perhaps the feature request here is to add a way to only backport to the most recent.

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Oct 31, 2019

/cc @cagedmantis Another issue you could look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.