html: EscapeString(`'`) should not be '

[gopherbot]

by peterthrun@ymail.com:

What steps will reproduce the problem?

http://play.golang.org/p/uKNBC4VM8I

What is the expected output?

html.EscapeString("'") →   '
template.HTMLEscapeString("'") →  '

What do you see instead?

html.EscapeString("'") →  '
template.HTMLEscapeString("'") →  '

Please provide any additional information below.

The character entity reference ' is not defined by the HTML standard
(http://www.w3.org/TR/REC-html40/sgml/entities.html)

The text/template HTMLEscapeString function does the right thing.

[rsc]

Comment 1:

Oops.  Looks like apos was introduced in HTML5 (and XML)
but wasn't in earlier versions of HTML.
Thanks.

Owner changed to @nigeltao.

Status changed to Accepted.

[robpike]

Comment 2:

Labels changed: added priority-soon, removed priority-triage.

[gopherbot]

Comment 3 by peterthrun@ymail.com:

To prevent regressions, the comment at
http://golang.org/src/pkg/text/template/funcs.go#L249 should be updated to mention that
apos is not supported by older browsers.

[nigeltao]

Comment 4:

This issue was closed by revision 6277656.

Status changed to Fixed.

[nigeltao]

Comment 5:

This issue was closed by revision 105ef9366b53.