Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: TestFormats failing again #34907

Closed
bcmills opened this issue Oct 14, 2019 · 2 comments
Closed

cmd/compile: TestFormats failing again #34907

bcmills opened this issue Oct 14, 2019 · 2 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 14, 2019

compile.TestFormats is failing in the builders again (#33915, #28621).

There is an empty cell in the dashboard, so it's hard to tell whether it was broken by CL 196781 (CC @rasky, @dr2chase) or CL 200582 (CC @mengzhuo, @cherrymui, @randall77).

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 14, 2019

Change https://golang.org/cl/201079 mentions this issue: cmd/compile: fix fmt test

@gopherbot gopherbot closed this in c2c2ba2 Oct 15, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 5, 2019

Change https://golang.org/cl/205440 mentions this issue: cmd/compile: do not skip TestFormats on short builders

pull bot pushed a commit to ksti/go that referenced this issue Nov 5, 2019
TestFormats adds ~3s of running time to the test, which may be
slightly annoying in an edit/compile/test cycle but is negligible in a
TryBot run.

The test keeps regressing in the longtest builders, requiring a manual
fix. Instead, run it even in short mode on the builders, so that
TryBot runs will detect regressions ahead of time.

Updates golang#34907
Updates golang#33915
Updates golang#28621

Change-Id: I6f9bf0f2ca929a743438310b86d85d8673c720bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/205440
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.