Skip to content

time: genzabbrs.go consistently fails to update Windows zones #34917

@bcmills

Description

@bcmills

There are currently two different command lines that claim to update zoneinfo_abbrs_windows.go:

// go run genzabbrs.go -output zoneinfo_abbrs_windows.go

//go:generate env ZONEINFO=$GOROOT/lib/time/zoneinfo.zip go run genzabbrs.go -output zoneinfo_abbrs_windows.go
(#15802; CC @alexbrainman)

Neither of those seems to work at the moment:

~/go/src/time$ go run genzabbrs.go -output zoneinfo_abbrs_windows.go
2019/10/15 09:31:00 Get "http://unicode.org/cldr/data/common/supplemental/windowsZones.xml": dial tcp 216.97.88.9:80: connect: connection timed out
exit status 1

~/go/src/time$ go generate time
2019/10/15 09:31:20 Get "http://unicode.org/cldr/data/common/supplemental/windowsZones.xml": dial tcp 216.97.88.9:80: connect: connection timed out
exit status 1
zoneinfo.go:13: running "env": exit status 1
Details
~/go/src/time$ go version
go version devel +4591f8a4dc Fri Oct 11 12:39:58 2019 -0400 linux/amd64

~/go/src/time$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/bcmills/.cache/go-build"
GOENV="/usr/local/google/home/bcmills/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/usr/local/google/home/bcmills"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/google/home/bcmills/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/google/home/bcmills/go/pkg/tool/linux_amd64"
GCCGO="/usr/local/google/home/bcmills/bin/gccgo"
AR="ar"
CC="gcc"
CXX="c++"
CGO_ENABLED="1"
GOMOD="/usr/local/google/home/bcmills/go/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build203139915=/tmp/go-build -gno-record-gcc-switches"

Noticed while investigating #34913.

Marking as a release-blocker, since presumably we want to keep zoneinfo_abbrs_windows.go in sync with the rest of the tzdata files we ship (#22487).

CC @andybons @ianlancetaylor @dsnet

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions