Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: net: add LookupSOA function #35061

Open
NerdsvilleCEO opened this issue Oct 21, 2019 · 7 comments

Comments

@NerdsvilleCEO
Copy link

@NerdsvilleCEO NerdsvilleCEO commented Oct 21, 2019

What version of Go are you using (go version)?

$ go version
go version go1.13 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env | egrep "GOARCH|GOOS"
GOARCH="amd64"
GOOS="linux"

What did you do?

Looked at source of net package under the net.go file

What did you expect to see?

LookupSOA functions

What did you see instead?

Not implemented, I am interested in helping implement this based on the other helpers such as LookupIP if these just haven't been implemented yet

@NerdsvilleCEO NerdsvilleCEO changed the title net: Missing LookupSOA, LookupPTR net: Missing LookupSOA Oct 22, 2019
@agnivade agnivade added this to the Unplanned milestone Oct 22, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 22, 2019

Change https://golang.org/cl/202599 mentions this issue: net: Add LookupSOA methods

@ianlancetaylor ianlancetaylor changed the title net: Missing LookupSOA proposal: net: add LookupSOA function Oct 22, 2019
@gopherbot gopherbot added the Proposal label Oct 22, 2019
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 22, 2019

This is new API so I've turned it into a proposal.

I wonder if this should be in the x/net package somewhere.

@NerdsvilleCEO

This comment has been minimized.

Copy link
Author

@NerdsvilleCEO NerdsvilleCEO commented Oct 22, 2019

@ianlancetaylor should we also move unused DNS related functions such as LookupTXT? There may be others as well

There is https://godoc.org/golang.org/x/net/dns/dnsmessage, maybe it can go in x/net/dns somewhere?

I understand the goal is to keep stdlib as minimal as possible

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 22, 2019

We can't move any existing functions. I'm just not sure whether any news ones are needed.

@NerdsvilleCEO

This comment has been minimized.

Copy link
Author

@NerdsvilleCEO NerdsvilleCEO commented Oct 22, 2019

Ok, should I close this issue and find an alternate solution or does this mean we are waiting :)

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 22, 2019

This issue is currently a proposal and the proposal review committee will look at it.

It's kind of up to you how you want to proceed.

@NerdsvilleCEO

This comment has been minimized.

Copy link
Author

@NerdsvilleCEO NerdsvilleCEO commented Oct 22, 2019

I am fine with whichever direction is decided, I will leave this open til there is a decision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.