Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: fix Gerrit reviewer email addresses #35078

Open
bradfitz opened this issue Oct 22, 2019 · 2 comments
Open

x/build/cmd/gopherbot: fix Gerrit reviewer email addresses #35078

bradfitz opened this issue Oct 22, 2019 · 2 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 22, 2019

I have three main email addresses (gmail.com, golang.org, google.com), with three corresponding Chrome identities/Google accounts.

So do many others on the Go team. (Or at least two)

And because I've clicked links to Gerrit reviews while signed into each of the three, Gerrit has helpfully signed me in & made an account for me.

Which then means my name shows up in the autocomplete list for "bradfitz" in three ways.

It's distracting when I get reviews to the wrong email account.

This just bit @ianlancetaylor too.

I realized we could just have a mapping table and make gopherbot fix the reviewers if it sees a wrong one added by mistake.

/cc @dmitshur @andybons @bcmills

@gopherbot gopherbot added this to the Unreleased milestone Oct 22, 2019
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 22, 2019

I've run into this too. I've worked around it by changing the name and status in my unwanted Gerrit profile to be the string "DO NOT USE":

It has been effective in that I haven't had any reviews sent to it since then.

Here's how it looks in Gerrit's autocompletion UI:


And because I've clicked links to Gerrit reviews while signed into each of the three, Gerrit has helpfully signed me in & made an account for me.

I think this Gerrit behavior is very unfriendly, especially since there's no way to delete or deactivate the account after it is created. We should file a bug/feature request against Gerrit to be able to resolve this problem more generally, rather than just for the Go project. And one less thing we have to maintain ourselves.

I realized we could just have a mapping table and make gopherbot fix the reviewers if it sees a wrong one added by mistake.

I imagine we can add a new field like UnwantedGerrit []string to the gophers.Person struct. When implementing this (just like any other active gopherbot feature), care needs to be taken to ensure gopherbot doesn't fight humans (too much) and doesn't take unbounded repetitive actions.

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 22, 2019

We should file a bug/feature request against Gerrit to be able to resolve this problem more generally, rather than just for the Go project.

There are some existing ones:

Those who are interested in this Gerrit problem being resolved should leave a "star" on the relevant issues to indicate interest, so that they are better prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants