Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: review compiler-generated symbol naming scheme #35088

Open
mdempsky opened this issue Oct 22, 2019 · 2 comments
Open

cmd/compile: review compiler-generated symbol naming scheme #35088

mdempsky opened this issue Oct 22, 2019 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@mdempsky
Copy link
Member

mdempsky commented Oct 22, 2019

cmd/compile generates a lot of linker symbols for internal objects, and we've amassed a number of ad hoc naming schemes for them. I'm concerned that there might be collisions, particularly with user-defined symbols.

We should review and probably catalog the existing symbol, and try to find a more uniform naming scheme that we can ensure is collision-free.

@mdempsky mdempsky added help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 22, 2019
@mdempsky mdempsky added this to the Unplanned milestone Oct 22, 2019
@aclements
Copy link
Member

aclements commented Oct 24, 2019

This may also relate to the linker rewrite. A lot of the compiler-generated symbols only have names for diagnostics purposes. In the new linker design, at least for compiler-generated symbols that aren't dupok, we can create symbols that aren't referenced by name at all.

/cc @jeremyfaller @cherrymui @thanm

@randall77
Copy link
Contributor

randall77 commented Oct 24, 2019

Related: #21940.

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants