Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: incorrectly rejects '@' character in directory names [1.13 backport] #35119

Closed
gopherbot opened this issue Oct 23, 2019 · 8 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 23, 2019

@jayconrod requested issue #35115 to be considered for backport to the next 1.13 minor release.

@gopherbot Please backport to go1.13

@jayconrod

This comment has been minimized.

Copy link
Contributor

@jayconrod jayconrod commented Oct 23, 2019

This was a regression in 1.13.3, caused by an earlier cherry-pick. There is a mildly annoying workaround (renaming the workspace directory). However, the fix is straightforward.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Oct 23, 2019

Change https://golang.org/cl/202763 mentions this issue: [release-branch.go1.13] cmd/go: ignore '@' when cleaning local and absolute file path args

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Oct 23, 2019

Do we know of anyone actually affected by this regression? (If not, let's not risk a cherry-pick.)

@jayconrod

This comment has been minimized.

Copy link
Contributor

@jayconrod jayconrod commented Oct 23, 2019

It was reported in microsoft/vscode-go#2858. VSCode and gopls don't use @ in directory names by convention though. Perhaps that person is the only one affected?

So yeah, let's not risk it.

@jayconrod jayconrod closed this Oct 23, 2019
@AlekSi

This comment has been minimized.

Copy link
Contributor

@AlekSi AlekSi commented Nov 1, 2019

So that wasn't really back ported? Can you remove milestone then?

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Nov 1, 2019

@AlekSi, by convention only the issues labeled CherryPickApproved are included in point releases. (If we're linking to the wrong search somewhere, we should fix the link; CC @andybons.)

@AlekSi

This comment has been minimized.

Copy link
Contributor

@AlekSi AlekSi commented Nov 1, 2019

You link to the milestone from there: https://golang.org/doc/devel/release.html#go1.13.minor Note that all issues in that milestone do not have that label.

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Nov 1, 2019

Note that all issues in that milestone do not have that label.

That was a bug. It has been fixed now. Sorry for any confusion.

You can use https://github.com/golang/go/issues?q=milestone%3AGo1.13.4+label%3ACherryPickApproved to see the list of backports that went into Go 1.13.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.