Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: tests fail on race TryBots after CL 201783 #35121

Closed
stamblerre opened this issue Oct 23, 2019 · 1 comment
Closed

x/tools/gopls: tests fail on race TryBots after CL 201783 #35121

stamblerre opened this issue Oct 23, 2019 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 23, 2019

The gopls cache relies on the internal/memoize package, which fails valid with -d=checkptr. CL 201783 added -d=checkptr to the -race flag, causing the gopls tests to fail on the race builders.

Related to #34964

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

@stamblerre stamblerre commented Oct 24, 2019

Fixed via CL 203078.

@stamblerre stamblerre closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.