Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/present: panic when serving presentation with .video #35142

Closed
echlebek opened this issue Oct 24, 2019 · 3 comments
Closed

x/tools/present: panic when serving presentation with .video #35142

echlebek opened this issue Oct 24, 2019 · 3 comments
Assignees
Milestone

Comments

@echlebek
Copy link

@echlebek echlebek commented Oct 24, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.7 linux/amd64

Does this issue reproduce with the latest release?

Unknown

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/eric/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/eric/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/eric/go/src/github.com/echlebek/lisa19-etcd/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build129608040=/tmp/go-build -gno-record-gcc-switches"

What did you do?

In a present slide set, attempt to embed an animated svg as a video.

.video animated.svg

What did you expect to see?

I was expecting to see the SVG rendered as a playable video, or an error.

What did you see instead?

The HTTP handler panicked.

May be related to #17561

@gopherbot gopherbot added this to the Unreleased milestone Oct 24, 2019
@gopherbot gopherbot added the Tools label Oct 24, 2019
@dmitshur dmitshur added the NeedsFix label Oct 25, 2019
@dmitshur dmitshur self-assigned this Oct 25, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2019

Change https://golang.org/cl/203477 mentions this issue: present: check if too few arguments to image, iframe, or video

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 25, 2019

Thanks for reporting.

I've sent CL 203477 to fix this.

@echlebek
Copy link
Author

@echlebek echlebek commented Oct 25, 2019

Cheers Dmitri! 🍻

@golang golang locked and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.