Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/ipv4: unsafe pointer conversion in (*ControlMessage).Parse via parseInterface #35174

Closed
bcmills opened this issue Oct 26, 2019 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 26, 2019

From the freebsd-amd64-race builder (https://build.golang.org/log/ee930a7bfe98820ea45ae0b5375a94ba4e9dd648):

--- FAIL: TestPacketConnReadWriteMulticastUDP (0.00s)
panic: runtime error: unsafe pointer conversion [recovered]
	panic: runtime error: unsafe pointer conversion

goroutine 9 [running]:
testing.tRunner.func1(0xc0000f0400)
	/tmp/workdir/go/src/testing/testing.go:881 +0x69f
panic(0x6c6520, 0xc00000e180)
	/tmp/workdir/go/src/runtime/panic.go:915 +0x370
golang.org/x/net/ipv4.parseInterface(0xc000012300, 0xc0001000c0, 0x38, 0x38)
	/tmp/workdir/gopath/src/golang.org/x/net/ipv4/control_bsd.go:38 +0x5c
golang.org/x/net/ipv4.(*ControlMessage).Parse(0xc000012300, 0xc000100080, 0x78, 0x78, 0x0, 0x8a3698)
	/tmp/workdir/gopath/src/golang.org/x/net/ipv4/control.go:92 +0x5b5
golang.org/x/net/ipv4.(*payloadHandler).ReadFrom(0xc0000fa240, 0xc000100000, 0x80, 0x80, 0x0, 0x728000, 0xc0000f8240, 0xf, 0x0, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/net/ipv4/payload_cmsg.go:56 +0x334
golang.org/x/net/ipv4_test.TestPacketConnReadWriteMulticastUDP(0xc0000f0400)
	/tmp/workdir/gopath/src/golang.org/x/net/ipv4/multicast_test.go:101 +0x300
testing.tRunner(0xc0000f0400, 0x6f0630)
	/tmp/workdir/go/src/testing/testing.go:916 +0x1a9
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:967 +0x652
FAIL	golang.org/x/net/ipv4	0.025s

CC @mdempsky @ianlancetaylor @mikioh

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 26, 2019
@bcmills bcmills added this to the Go1.14 milestone Oct 26, 2019
@bcmills bcmills changed the title x/net/ipv4: TestPacketConnReadWriteMulticastUDP failing on freebsd-amd64-race due to unsafe pointer conversion x/net/ipv4: unsafe pointer conversion in (*ControlMessage).Parse via parseInterface Oct 26, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 26, 2019

Change https://golang.org/cl/203400 mentions this issue: ipv4: fix unsafe pointer conversion in parseInterface

@golang golang locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

2 participants