x/build: windows-amd64-longtest failing on x/mobile

[bcmills]

https://build.golang.org/log/2c7d5ffd37cce526cbf896b708d104b98a7f21f9 shows the windows-amd64-longtest running (and failing on) the x/mobile repo.

Should this builder be running x/moble at all?

CC @bradfitz @dmitshur @toothrot

[bradfitz]

No, it shouldn't.

[bradfitz]

Uh,

        addBuilder(BuildConfig{
                Name:      "windows-amd64-longtest",
                HostType:  "host-windows-amd64-2016",
                MaxAtOnce: 1,
                Notes:     "Windows Server 2016 with go test -short=false",
                buildsRepo: func(repo, branch, goBranch string) bool {
                        return repo == "go" || (branch == "master" && goBranch == "master")
                },

It's already configured to only build go@master.

So, ummmm?

[bcmills]

Looking at https://build.golang.org/?repo=golang.org%2fx%2fmobile, it appears that the other longtest builders are also running x/mobile for some reason.

[bcmills]

(And apparently some random freebsd builders on occasion..?)

[dmitshur]

buildsRepo: func(repo, branch, goBranch string) bool {
  return repo == "go" || (branch == "master" && goBranch == "master")
},

It's already configured to only build go@master.

Isn't that saying "build all branches in the Go repo plus the master branch of any other repo with Go tip"? It's ||, not &&.

[bradfitz]

Derp dee derp. I totally didn't read that earlier.

Okay, this is an easy fix then.

[gopherbot]

Change https://golang.org/cl/203885 mentions this issue: dashboard: adjust the windows-amd64-longtest policy