x/build: windows-amd64-longtest failing on x/mobile #35185
Closed
Milestone
Comments
No, it shouldn't. |
Uh, addBuilder(BuildConfig{
Name: "windows-amd64-longtest",
HostType: "host-windows-amd64-2016",
MaxAtOnce: 1,
Notes: "Windows Server 2016 with go test -short=false",
buildsRepo: func(repo, branch, goBranch string) bool {
return repo == "go" || (branch == "master" && goBranch == "master")
}, It's already configured to only build go@master. So, ummmm? |
Looking at https://build.golang.org/?repo=golang.org%2fx%2fmobile, it appears that the other |
(And apparently some random |
Isn't that saying "build all branches in the Go repo plus the master branch of any other repo with Go tip"? It's |
Derp dee derp. I totally didn't read that earlier. Okay, this is an easy fix then. |
Change https://golang.org/cl/203885 mentions this issue: |
codebien
added a commit
to codebien/build
that referenced
this issue
Nov 13, 2019
It shouldn't build more repos than windows-amd64-2016. Fixes golang/go#35185 Change-Id: I310e2ccc521d88692fcf904fe53b4bae94f3f0f0 Reviewed-on: https://go-review.googlesource.com/c/build/+/203885 Reviewed-by: Bryan C. Mills <bcmills@google.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://build.golang.org/log/2c7d5ffd37cce526cbf896b708d104b98a7f21f9 shows the
windows-amd64-longtest
running (and failing on) thex/mobile
repo.Should this builder be running x/moble at all?
CC @bradfitz @dmitshur @toothrot
The text was updated successfully, but these errors were encountered: