Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: windows-amd64-longtest failing on x/mobile #35185

Closed
bcmills opened this issue Oct 26, 2019 · 7 comments
Closed

x/build: windows-amd64-longtest failing on x/mobile #35185

bcmills opened this issue Oct 26, 2019 · 7 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 26, 2019

https://build.golang.org/log/2c7d5ffd37cce526cbf896b708d104b98a7f21f9 shows the windows-amd64-longtest running (and failing on) the x/mobile repo.

Should this builder be running x/moble at all?

CC @bradfitz @dmitshur @toothrot

@gopherbot gopherbot added this to the Unreleased milestone Oct 26, 2019
@gopherbot gopherbot added the Builders label Oct 26, 2019
@bcmills bcmills added NeedsInvestigation and removed Builders labels Oct 26, 2019
@gopherbot gopherbot added the Builders label Oct 26, 2019
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 28, 2019

No, it shouldn't.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 28, 2019

Uh,

        addBuilder(BuildConfig{
                Name:      "windows-amd64-longtest",
                HostType:  "host-windows-amd64-2016",
                MaxAtOnce: 1,
                Notes:     "Windows Server 2016 with go test -short=false",
                buildsRepo: func(repo, branch, goBranch string) bool {
                        return repo == "go" || (branch == "master" && goBranch == "master")
                },

It's already configured to only build go@master.

So, ummmm?

@bcmills
Copy link
Member Author

@bcmills bcmills commented Oct 28, 2019

Looking at https://build.golang.org/?repo=golang.org%2fx%2fmobile, it appears that the other longtest builders are also running x/mobile for some reason.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Oct 28, 2019

(And apparently some random freebsd builders on occasion..?)

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 28, 2019

buildsRepo: func(repo, branch, goBranch string) bool {
  return repo == "go" || (branch == "master" && goBranch == "master")
},

It's already configured to only build go@master.

Isn't that saying "build all branches in the Go repo plus the master branch of any other repo with Go tip"? It's ||, not &&.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 28, 2019

Derp dee derp. I totally didn't read that earlier.

Okay, this is an easy fix then.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 28, 2019

Change https://golang.org/cl/203885 mentions this issue: dashboard: adjust the windows-amd64-longtest policy

codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
It shouldn't build more repos than windows-amd64-2016.

Fixes golang/go#35185

Change-Id: I310e2ccc521d88692fcf904fe53b4bae94f3f0f0
Reviewed-on: https://go-review.googlesource.com/c/build/+/203885
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.