Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: CL 202581 broke tests at tip #35226

Closed
stamblerre opened this issue Oct 29, 2019 · 2 comments
Closed

x/tools/gopls: CL 202581 broke tests at tip #35226

stamblerre opened this issue Oct 29, 2019 · 2 comments
Labels
Tools gopls
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 29, 2019

Example logs: https://build.golang.org/log/b25de7d549ecbd0ae1ee4b93722a2584b4efe3ac

#34348 will help us catch these issues in advance in the future.
@gopherbot gopherbot added this to the Unreleased milestone Oct 29, 2019
This was referenced Oct 29, 2019
Open
Closed
Closed
@stamblerre

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@stamblerre stamblerre commented Oct 30, 2019

https://golang.org/cl/204041 fixed the majority of these failures.
The remaining failure has been diagnosed with a test case in go/ast (see https://golang.org/cl/204197).
@stamblerre

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@stamblerre stamblerre commented Oct 30, 2019

This has been fixed as of https://golang.org/cl/204202.
@stamblerre stamblerre closed this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tools gopls
Projects
None yet
Milestone
  Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot
You can’t perform that action at this time.