cmd/vet: false positives for FP assembly #35264
Closed
Labels
Comments
I have a fix for the complex ones. We should allow a single instruction to load both parts of a complex value. Those last two lines are intended. The name of the return value for an anonymous return value is "ret", not "sum". You can either change the assembly to use "ret", or change the prototype to:
|
Change https://golang.org/cl/204537 mentions this issue: |
Change https://golang.org/cl/204538 mentions this issue: |
Thanks, @randall77. I had thought I had tried that change in |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Nov 4, 2019
… one instruction Update golang/go#35264 Change-Id: I4317c75cc5acc592ab739b0aab4cd85280858219 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204537 Reviewed-by: Alan Donovan <adonovan@google.com> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Change https://golang.org/cl/205240 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Nov 5, 2019
Actual fix will be submitted to x/tools and vendored. This is just an end-to-end test for vet after that is done. Update #35264 Change-Id: I1a63f607e7cfa7aafee23c2c081086c276d3c38c Reviewed-on: https://go-review.googlesource.com/c/go/+/204538 Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
No complaints.
What did you see instead?
See gonum/gonum#79.
The text was updated successfully, but these errors were encountered: