Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/vet: false positives for FP assembly #35264
What version of Go are you using (
I have a fix for the complex ones. We should allow a single instruction to load both parts of a complex value.
Those last two lines are intended. The name of the return value for an anonymous return value is "ret", not "sum". You can either change the assembly to use "ret", or change the prototype to:
… one instruction Update golang/go#35264 Change-Id: I4317c75cc5acc592ab739b0aab4cd85280858219 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204537 Reviewed-by: Alan Donovan <firstname.lastname@example.org> Run-TryBot: Keith Randall <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org>
Actual fix will be submitted to x/tools and vendored. This is just an end-to-end test for vet after that is done. Update #35264 Change-Id: I1a63f607e7cfa7aafee23c2c081086c276d3c38c Reviewed-on: https://go-review.googlesource.com/c/go/+/204538 Run-TryBot: Keith Randall <email@example.com> Reviewed-by: Alan Donovan <firstname.lastname@example.org>