Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestPingPongHog is flaky #35271

Open
bcmills opened this issue Oct 31, 2019 · 4 comments
Assignees
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 31, 2019

From windows-amd64-longtest (https://build.golang.org/log/3fbe37b41ed88143f4b6d6f6e277e99891537be7):

--- FAIL: TestPingPongHog (0.11s)
    proc_test.go:460: want hogCount/lightCount in [0.2, 5]; got 51000000/6733000 = 7.574632407544928
FAIL
FAIL	runtime	288.181s

CC @aclements @mknyszek

@bcmills bcmills added this to the Go1.14 milestone Oct 31, 2019
@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Oct 31, 2019

linux-amd64-longtest: https://build.golang.org/log/8f4ed420d92d7a3872a0701928f301386266e77f

I'm guessing this probably turned flaky due to the goroutine-preemption changes?

@bcmills bcmills changed the title runtime: TestPingPongHog failure on windows-amd64-longtest runtime: TestPingPongHog is flaky Oct 31, 2019
@bcmills bcmills added the Soon label Nov 1, 2019
@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Nov 1, 2019

This is preventing me from getting meaningful TryBot results on Windows for CL 204521.

(https://storage.googleapis.com/go-build-log/66ca91a7/windows-amd64-longtest_cfa17417.log)

@mknyszek

This comment has been minimized.

Copy link
Contributor

@mknyszek mknyszek commented Nov 7, 2019

This is now failing much more consistently on the linux longtests, as of 21445b0.

The scavenger is likely going to sleep and waking up much more often than before (though I'm not sure that it's enough to still matter. The time spent "measuring" is 100 ms, though, so I suppose I could see that making this worse.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 8, 2019

Change https://golang.org/cl/206098 mentions this issue: runtime: skip TestPingPongHog on builders

gopherbot pushed a commit that referenced this issue Nov 8, 2019
This test is failing consistently in the longtest builders,
potentially masking regressions in other packages.

Updates #35271

Change-Id: Idc03171c0109b5c8d4913e0af2078c1115666897
Reviewed-on: https://go-review.googlesource.com/c/go/+/206098
Reviewed-by: Carlos Amedee <carlos@golang.org>
@bcmills bcmills removed the Soon label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.