Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: Test*EOF flaky #35275

Closed
bcmills opened this issue Oct 31, 2019 · 9 comments
Closed

os: Test*EOF flaky #35275

bcmills opened this issue Oct 31, 2019 · 9 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 31, 2019

darwin-amd64-10_14 (https://build.golang.org/log/e527731127351d19a8868d360bd6b534590f69f0):

--- FAIL: TestFifoEOF (60.05s)
    fifo_test.go:100: line 0
    fifo_test.go:100: line 1
    fifo_test.go:100: line 2
    fifo_test.go:108: timed out waiting for read
    fifo_test.go:86: error closing reader: close /var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/tmp/TestFifoEOF585114092/fifo: file already closed
FAIL
FAIL	os	60.911s

May relate to #25877 (CC @ianlancetaylor).

@bcmills bcmills added this to the Go1.14 milestone Oct 31, 2019
@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Oct 31, 2019

A very similar failure in TestPipeEOF on aix-ppc64 (https://build.golang.org/log/836b814bee1107744a77bf2767d3f240586f6028):

--- FAIL: TestPipeEOF (1.01s)
    pipe_test.go:378: line 0
    pipe_test.go:378: line 1
    pipe_test.go:386: timed out waiting for read
    pipe_test.go:378: line 2
    pipe_test.go:375: read |0: file already closed
    pipe_test.go:364: error closing reader: close |0: file already closed
FAIL
FAIL	os	1.941s
@bcmills bcmills changed the title os: TestFifoEOF failure on darwin-amd64-10_14 os: Test*EOF flaky Oct 31, 2019
@mknyszek

This comment has been minimized.

Copy link
Contributor

@mknyszek mknyszek commented Nov 1, 2019

Seen on trybots (windows-386-2008), and I'm 99% it's not related to those changes: https://storage.googleapis.com/go-build-log/5064a99f/windows-386-2008_ac9f4654.log

--- FAIL: TestPipeEOF (1.00s)
    pipe_test.go:378: line 0
    pipe_test.go:378: line 1
    pipe_test.go:378: line 2
    pipe_test.go:386: timed out waiting for read
    pipe_test.go:375: read |0: file already closed
    pipe_test.go:364: error closing reader: close |0: file already closed
FAIL
FAIL	os	3.570s
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 1, 2019

So far, the TestFifoEOF error is happening only on Darwin. The TestPipeEOF error has not yet been seen on Darwin. Though I agree they look quite similar.

2019-10-30T21:43:57-6becb03/darwin-arm-mg912baios
2019-10-31T09:49:57-1085560/darwin-amd64-10_14
2019-10-31T09:49:57-1085560/darwin-arm64-corellium
2019-10-31T17:21:56-48c0cef/darwin-386-10_14

@mknyszek

This comment has been minimized.

Copy link
Contributor

@mknyszek mknyszek commented Nov 1, 2019

@ianlancetaylor I saw a TestFifoEOF error on a linux/amd64 trybot just now: https://storage.googleapis.com/go-build-log/22734f54/linux-amd64_a7c99ff2.log

--- FAIL: TestFifoEOF (1.01s)
    fifo_test.go:108: timed out waiting for read
    fifo_test.go:100: line 0
    fifo_test.go:97: read /workdir/tmp/TestFifoEOF684921827/fifo: file already closed
    fifo_test.go:86: error closing reader: close /workdir/tmp/TestFifoEOF684921827/fifo: file already closed
    fifo_test.go:66: error writing to fifo: write /workdir/tmp/TestFifoEOF684921827/fifo: broken pipe
FAIL
FAIL	os	1.601s
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 1, 2019

Thanks. I haven't had any luck reproducing this.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 1, 2019

There is certainly a chance that this will be fixed by https://golang.org/cl/204800, but it's hard to know for sure.

@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented Nov 4, 2019

https://storage.googleapis.com/go-build-log/52250b89/windows-386-2008_e048933d.log

--- FAIL: TestPipeEOF (1.00s)
    pipe_test.go:378: line 0
    pipe_test.go:378: line 1
    pipe_test.go:378: line 2
    pipe_test.go:386: timed out waiting for read
    pipe_test.go:364: error closing reader: close |0: file already closed

From the https://golang.org/cl/204377 TryBot.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 4, 2019

CL 204800 is still awaiting review.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 6, 2019

This hasn't happened since https://golang.org/cl/204800 was committed. It is almost certainly fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.