html/template: remove noescape support

[rsc]

There is some magic surrounding functions named "noescape" in html/template.
This should be cleaned up and documented, or else removed.
I would prefer documenting it, since it is useful.

[rsc]

Comment 1:

Also, how do you avoid query parameter escaping without 'noescape'.  Does the URL type
work for that?  If so, that should be documented.  If not, there should be a type that
does.

[gopherbot]

Comment 2 by mikesamuel:

> Also, how do you avoid query parameter escaping without 'noescape'.
The URL type
(http://code.google.com/p/go/source/browse/src/pkg/html/template/content.go#55) will
pass through query parameter escaping unchanged.
Relevant testcases:
 * http://code.google.com/p/go/source/browse/src/pkg/html/template/content_test.go#186
 * http://code.google.com/p/go/source/browse/src/pkg/html/template/content_test.go#199
The documentation for content types is pretty sparse since a full treatment was deemed
overkill.  The relevant docs are
http://code.google.com/p/go/source/browse/src/pkg/html/template/doc.go#145
> Types HTML, JS, URL, and others from content.go can carry safe content that is
> exempted from escaping.

[rsc]

Comment 3:

I suggest to revise the type doc for URL from saying
    URL encapsulates a known safe URL as defined in RFC 3896.
to saying
    URL encapsulates a known safe URL as defined in RFC 3896 or a URL substring.

[gopherbot]

Comment 4 by salviati.gnu:

ExecuteTemplate paniced with "function "noescape" not defined" when I tried to used it
like {{noescape .TrustedHTML}}.
Is there any way of directing a trusted code from a template at all?

[minux]

Comment 5:

@salviati.gnu: issue tracker is not for questions like this, you'd
better ask on golang-nuts mailing list.
you can use template.HTML type for known safe strings.

[rsc]

Comment 6:

I made the doc change from comment #3. That leaves the question: document noescape and
add a function with that name by default, or remove the support for it.
@mikesamuel, any opinion?
I lean toward removing it.

[rsc]

Comment 7:

Labels changed: added size-m.

[gopherbot]

Comment 8 by mikesamuel:

I lean towards removing it too.

[rsc]

Comment 9:

Sounds good to me.

[adg]

Comment 10:

https://golang.org/cl/7142048

Owner changed to @adg.

Status changed to Started.

[adg]

Comment 11:

This issue was closed by revision c022943.

Status changed to Fixed.

[gopherbot]

Comment 12 by Raincious:

Good work!
Starting from this point, people had to reimplementing it by their own in each of their
application.
Thanks.