Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: TestMutexFairness flaky on openbsd-*-62 #35281

Closed
bcmills opened this issue Oct 31, 2019 · 2 comments
Assignees
Milestone

Comments

@bcmills bcmills added this to the Go1.14 milestone Oct 31, 2019
@danscales danscales self-assigned this Nov 12, 2019
@danscales

This comment has been minimized.

Copy link

@danscales danscales commented Nov 13, 2019

I was able to reproduce this reliably at the change 02a5502 listed in one of the failure instances, by repeating this 100 times:

gomote run user-danscales-openbsd-amd64-62-0 go/bin/go test sync -test.run TestMutexFairness -test.count=1 -test.timeout=15s

Using this same way to reproduce, I found that it started happening when Ian turned on the new timer code. It is fixed (not reproducible) in the current master, and by bisecting, I found it was fixed by Ian's commit

d80ab3e : runtime: wake netpoller when dropping P, don't sleep too long in sysmon

@ianlancetaylor does that make sense to you (seems reasonable to me based on the description of the change and the bugs that it fixed). If so, I think we can close this bug.

(Also, doesn't seem like it has been happening on the builder for the last week, as expected.)

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 13, 2019

Yes, I expect that was fixed by the timer change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.