Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/go: test sums of zip files created in direct mode #35290
We currently have minimal test coverage on code that creates module zip files from repositories.
We should have a test that fails if the sum changes for a zip created for a given module path and version.
The test should also alert us when the SHA-256 sum of the created zip file changes. These sums don't need to be stable; only content sums must not change. However, we should be aware of accidental changes to the way zip files are built.
zip.Create is now used to filter and translate zip files from VCS tools. zip.Unzip is now used instead of Unzip. Fixes #35290 Change-Id: I4aa41b2e96bf147c09db43d1d189b8393cafb06f Reviewed-on: https://go-review.googlesource.com/c/go/+/204917 Run-TryBot: Jay Conrod <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Bryan C. Mills <firstname.lastname@example.org>