Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: test sums of zip files created in direct mode #35290

Closed
jayconrod opened this issue Oct 31, 2019 · 3 comments
Closed

cmd/go: test sums of zip files created in direct mode #35290

jayconrod opened this issue Oct 31, 2019 · 3 comments
Assignees
Milestone

Comments

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Oct 31, 2019

We currently have minimal test coverage on code that creates module zip files from repositories.

We should have a test that fails if the sum changes for a zip created for a given module path and version.

The test should also alert us when the SHA-256 sum of the created zip file changes. These sums don't need to be stable; only content sums must not change. However, we should be aware of accidental changes to the way zip files are built.

@jayconrod jayconrod added this to the Go1.14 milestone Oct 31, 2019
@jayconrod jayconrod self-assigned this Oct 31, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 31, 2019

Change https://golang.org/cl/204643 mentions this issue: cmd/go/internal/modfetch: add zip sums and hashes to TestCodeRepo

gopherbot pushed a commit that referenced this issue Nov 1, 2019
Updates #35290

Change-Id: I09cad17f09e78c2bf6a9de98b01f13ed383ca006
Reviewed-on: https://go-review.googlesource.com/c/go/+/204643
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 1, 2019

Change https://golang.org/cl/204838 mentions this issue: cmd/go/internal/modfetch/zip_sum_test: long test for zip sum stability

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 1, 2019

Change https://golang.org/cl/204917 mentions this issue: cmd/go/internal/modfetch: switch to golang.org/x/mod/zip

@gopherbot gopherbot closed this in f7d0a42 Nov 7, 2019
gopherbot pushed a commit that referenced this issue Nov 7, 2019
zip.Create is now used to filter and translate zip files from VCS tools.

zip.Unzip is now used instead of Unzip.

Fixes #35290

Change-Id: I4aa41b2e96bf147c09db43d1d189b8393cafb06f
Reviewed-on: https://go-review.googlesource.com/c/go/+/204917
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.