Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestCloseWithBlockingReadByNewFile on windows #35344

Closed
bradfitz opened this issue Nov 4, 2019 · 4 comments
Closed

os: TestCloseWithBlockingReadByNewFile on windows #35344

bradfitz opened this issue Nov 4, 2019 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows release-blocker
Milestone
Go1.14

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Nov 4, 2019

I've seen this a few times recently (since the new timers?):

https://storage.googleapis.com/go-build-log/5a6599b5/windows-amd64-2016_ed10f21d.log

ok  	net/smtp	0.044s
ok  	net/textproto	0.035s
ok  	net/url	0.032s
--- FAIL: TestCloseWithBlockingReadByNewFile (1.00s)
    pipe_test.go:312: timed out waiting for Read and Close
FAIL
FAIL	os	3.932s
FAIL
2019/11/04 16:29:17 Failed: exit status 1

/cc @ianlancetaylor
@bradfitz bradfitz added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 4, 2019
@bradfitz bradfitz added this to the Go1.14 milestone Nov 4, 2019
@ianlancetaylor
Copy link
Member

2019-10-31T17:09:50-7de15e3/windows-amd64-longtest
2019-11-01T22:07:56-dc39be8/windows-amd64-2016
2019-11-03T19:43:59-ab4a71f/solaris-amd64-oraclerel
2019-11-04T01:28:26-6b67f7d/windows-amd64-2016

@ianlancetaylor
Copy link
Member

I think there is a decent chance that this was fixed by https://golang.org/cl/204800.

@ianlancetaylor
Copy link
Member

2019-11-08T16:35:06-17722c2/windows-amd64-2016

@ianlancetaylor
Copy link
Member

This hasn't happened since November 8. findflakes thinks this is fixed, so I'm calling this fixed by one of the timers CLs since the last occurrence. We can reopen if it happens again.

@golang golang locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows release-blocker
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
3 participants
@bradfitz @ianlancetaylor @gopherbot