Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: TestCloseWithBlockingReadByNewFile on windows #35344

Closed
bradfitz opened this issue Nov 4, 2019 · 4 comments
Closed

os: TestCloseWithBlockingReadByNewFile on windows #35344

bradfitz opened this issue Nov 4, 2019 · 4 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 4, 2019

I've seen this a few times recently (since the new timers?):

https://storage.googleapis.com/go-build-log/5a6599b5/windows-amd64-2016_ed10f21d.log

ok  	net/smtp	0.044s
ok  	net/textproto	0.035s
ok  	net/url	0.032s
--- FAIL: TestCloseWithBlockingReadByNewFile (1.00s)
    pipe_test.go:312: timed out waiting for Read and Close
FAIL
FAIL	os	3.932s
FAIL
2019/11/04 16:29:17 Failed: exit status 1

/cc @ianlancetaylor

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 6, 2019

I think there is a decent chance that this was fixed by https://golang.org/cl/204800.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 14, 2019

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 5, 2019

This hasn't happened since November 8. findflakes thinks this is fixed, so I'm calling this fixed by one of the timers CLs since the last occurrence. We can reopen if it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.