Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
runtime: TestNetpollDeadlock flakes across the board #35353
Seems to have coincided with this rarer semi-related flake, which I noticed at https://storage.googleapis.com/go-build-log/b7ab0107/linux-amd64_99c6e062.log
As a side-effect ensure that netpollinited only reports true when netpoll initialization is complete. Fixes #35282 Updates #35353 Change-Id: I21f08a04fcf229e0de5e6b5ad89c990426ae9b89 Reviewed-on: https://go-review.googlesource.com/c/go/+/204937 Run-TryBot: Ian Lance Taylor <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>
I reproduced this on linux-amd64 at 1da575a (the latest test failure above) by repeating this 100 times:
(usually happened within about 20 times). Using this reproduction case, I showed that it was also fixed by Ian's commit d80ab3e ("runtime: wake netpoller when dropping P, don't sleep too long in sysmon"). The failure is reproducible in commit immediate before Ian's, and not reproducible with Ian's commit.
So, I think we can close this bug as well.