Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestNetpollDeadlock flakes across the board #35353

Closed
FiloSottile opened this issue Nov 4, 2019 · 7 comments

Comments

@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented Nov 4, 2019

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 4, 2019

The netpollBreak write failed with 9 failures should be fixed by https://golang.org/cl/204937, which is awaiting review.

I'm less sure about the TestNetpollDeadlock failures. Let's see if they still happen now that CL 204800 is in.

@FiloSottile

This comment has been minimized.

Copy link
Member Author

@FiloSottile FiloSottile commented Nov 4, 2019

(FYI you did not assign a reviewer on CL 204937.)

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 4, 2019

It wasn't in anyone's particular speciality. I left it for the default approach.

gopherbot pushed a commit that referenced this issue Nov 5, 2019
As a side-effect ensure that netpollinited only reports true when
netpoll initialization is complete.

Fixes #35282
Updates #35353

Change-Id: I21f08a04fcf229e0de5e6b5ad89c990426ae9b89
Reviewed-on: https://go-review.googlesource.com/c/go/+/204937
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 5, 2019

Change https://golang.org/cl/204937 mentions this issue: runtime: don't return from netpollGenericInit until init is complete

@danscales

This comment has been minimized.

Copy link

@danscales danscales commented Nov 13, 2019

I reproduced this on linux-amd64 at 1da575a (the latest test failure above) by repeating this 100 times:

go test runtime -test.run TestNetpollDeadlock -test.count=100

(usually happened within about 20 times). Using this reproduction case, I showed that it was also fixed by Ian's commit d80ab3e ("runtime: wake netpoller when dropping P, don't sleep too long in sysmon"). The failure is reproducible in commit immediate before Ian's, and not reproducible with Ian's commit.

So, I think we can close this bug as well.

@danscales danscales closed this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.