Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: import name not added in certain cases #35401

Closed
heschik opened this issue Nov 6, 2019 · 1 comment
Closed

x/tools/gopls: import name not added in certain cases #35401

heschik opened this issue Nov 6, 2019 · 1 comment
Assignees
@heschik
Labels
FrozenDueToAge Tools gopls
Milestone
Unreleased

Comments

@heschik
Copy link
Contributor

@heschik heschik commented Nov 6, 2019

Followup for #35397 and https://golang.org/cl/205657. We should really call importPathToAssumedName somehow here and set up a Name the same way as goimports would.

cc @muirdm
@gopherbot gopherbot added this to the Unreleased milestone Nov 6, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 13, 2019

Change https://golang.org/cl/206890 mentions this issue: internal/lsp/source: give more imports names
@golang golang locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heschik heschik

Labels
FrozenDueToAge Tools gopls
Projects
None yet
Milestone
Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@gopherbot @heschik
You can’t perform that action at this time.