Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestLinuxSendfile failing on mips64 #35423

Closed
bcmills opened this issue Nov 7, 2019 · 6 comments
Closed

net/http: TestLinuxSendfile failing on mips64 #35423

bcmills opened this issue Nov 7, 2019 · 6 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 7, 2019

linux-mips64-rtrk (https://build.golang.org/log/08c75d4dfe5a50784afe5f032e5510cdc2e4ec8f):

--- FAIL: TestLinuxSendfile (0.37s)
    fs_test.go:1165: no sendfile system call found in:
        [pid 11110] +++ exited with 0 +++
        [pid 11106] +++ exited with 0 +++
        [pid 11109] +++ exited with 0 +++
        [pid 11108] +++ exited with 0 +++
        [pid 11107] +++ exited with 0 +++
        +++ exited with 0 +++
FAIL
FAIL	net/http	19.315s

See previously #18008.

CC @bradfitz @cherrymui @bogojevic @milanknezevic

@bcmills bcmills added this to the Go1.14 milestone Nov 7, 2019
@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Nov 7, 2019

Does the builder has 64-bit user space? As seen in #18008, the strace command that is not using 64-bit ABI may not work.

@milanknezevic
Copy link
Contributor

@milanknezevic milanknezevic commented Nov 7, 2019

@cherrymui The builder has 32-bit user space.

@milanknezevic
Copy link
Contributor

@milanknezevic milanknezevic commented Nov 8, 2019

@cherrymui @bradfitz The solution could be to modify the test to check if "n64:sendfile" syscall is used on mips64. Is that ok?

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Nov 8, 2019

I think I tried that in #18008 (comment)

That was a few years ago. Things may be different now.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 8, 2019

Change https://golang.org/cl/206178 mentions this issue: net/http: relax TestLinuxSendfile, trace all system calls, match n64:sendfile

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Nov 8, 2019

Ok, apparently now we no longer match the arguments, so this may work.

@gopherbot gopherbot closed this in 7a5e0fe Nov 8, 2019
@golang golang locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.