Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
This is needed to ensure that Apple’s notarization service can check that the
The SDK is not properly specified in the
All other binaries built with the toolchain have the correct values:
The fix for this will likely need to be backported. Hopefully it’s simple.
The fact that the SDK isn’t specified in the Mach-O headers makes me wonder if the xcode toolchain we’re using to compile cgo binaries at release time may need to be updated. When I build the toolchain on a
If the Go linker detects a load command in an external .o file, it will use that. We can't just pass
Perhaps it's enough to update/fix the toolchain used to build Go release. However, we could also expand the linker check above ("machoPlatform == 0") to trigger when the version and sdk are less than 10.9 in external linking mode. If you do that, please keep my https://go-review.googlesource.com/c/go/+/206337 in mind to only use the macOS load command for macOS binaries.