Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cover: consistently segfaulting in cmd/go.TestScript/cover_.* at head #35461

Closed
bcmills opened this issue Nov 8, 2019 · 4 comments
Closed
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Nov 8, 2019

cmd/cover started segfaulting in unit tests at some point between CL 201763 and CL 201765.

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/cover_pkgall_runtime (16.90s)
        script_test.go:192: 
            # Issue 23882 (16.904s)
            > [short] skip
            > go test -coverpkg=all x
            [stdout]
            ok  	x	0.004s	coverage: 14.8% of statements in all
            > stdout ok[\s\S]+?coverage
            > [!race] stop
            > go test -coverpkg=all -race x
            [stdout]
            signal: segmentation fault (core dumped)
            FAIL	x	0.100s
            FAIL
            [exit status 1]
            FAIL: testdata/script/cover_pkgall_runtime.txt:12: unexpected command failure
            
    --- FAIL: TestScript/cover_atomic_pkgall (16.33s)
        script_test.go:192: 
            > env GO111MODULE=off
            > [short] skip
            > go test -coverpkg=all -covermode=atomic x
            [stdout]
            ok  	x	0.006s	coverage: 15.0% of statements in all
            > stdout ok[\s\S]+?coverage
            > [!race] stop
            > go test -coverpkg=all -race x
            [stdout]
            signal: segmentation fault (core dumped)
            FAIL	x	0.106s
            FAIL
            [exit status 1]
            FAIL: testdata/script/cover_atomic_pkgall.txt:10: unexpected command failure
            
FAIL
FAIL	cmd/go	172.799s

The failure was initially masked in the builders by #35271.

CC @mknyszek @aclements @cherrymui @mdempsky

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Nov 8, 2019
@bcmills bcmills added this to the Go1.14 milestone Nov 8, 2019
@bcmills bcmills changed the title cmd/cover: consistently segfaulting in TestScript/cover_.* at head cmd/cover: consistently segfaulting in cmd/go.TestScript/cover_.* at head Nov 8, 2019
@bcmills
Copy link
Member Author

bcmills commented Nov 8, 2019

Bisected to CL 201765.

@mknyszek
Copy link
Contributor

mknyszek commented Nov 8, 2019

ah! thanks for the bisection. I'll look into this now.

@gopherbot
Copy link

Change https://golang.org/cl/206199 mentions this issue: runtime: copy some functions from math/bits to runtime/internal/sys

@mknyszek
Copy link
Contributor

mknyszek commented Nov 8, 2019

@cherrymui and @dr2chase found the problem and have a fix.

The fix worsens performance since we no longer use intrinsics for bit operations, but they have a follow-up which will intrinsify the new functions.

@golang golang locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Development

No branches or pull requests

3 participants