Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: crypto/tls expose names for CurveID and SignatureScheme #35499

Open
izolight opened this issue Nov 11, 2019 · 2 comments
Open

proposal: crypto/tls expose names for CurveID and SignatureScheme #35499

izolight opened this issue Nov 11, 2019 · 2 comments

Comments

@izolight
Copy link

@izolight izolight commented Nov 11, 2019

The constants for CurveID and SignatureScheme don't have any String() methods.
This makes printing these values (for example in log files) awkward as there is just a number.
To workaround this one can make a map to lookup from the constants to some friendly name (the constant name). As the constants already have custom types it would be best to implement the stringer interface for them in the standard library.
The idea is similiar to #30325
I created a first draft in #35297

@izolight izolight changed the title crypto/tls expose names for CurveID and SignatureScheme proposal: crypto/tls expose names for CurveID and SignatureScheme Nov 11, 2019
@gopherbot gopherbot added this to the Proposal milestone Nov 11, 2019
@gopherbot gopherbot added the Proposal label Nov 11, 2019
@katiehockman

This comment has been minimized.

Copy link
Member

@katiehockman katiehockman commented Nov 11, 2019

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 21, 2019

Change https://golang.org/cl/208226 mentions this issue: crypto/tls: add {SignatureScheme,CurveID,ClientAuthType}.String()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.