Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upproposal: cmd/go: have `go get`... look in vendored caches for dependencies #35510
Comments
This comment has been minimized.
This comment has been minimized.
/cc @bcmills |
This comment has been minimized.
This comment has been minimized.
Per https://golang.org/cmd/go/#hdr-Add_dependencies_to_current_module_and_install_them:
The |
This comment has been minimized.
This comment has been minimized.
As @mvdan and @bcmills pointed out, this is infeasible. The vendor directory by design does not contain full modules, only necessary packages for a build. @mcandre, as of Go 1.14 the go command will load packages from vendor automatically when it exists, so that will help "more reproducible development environments and less network strain" during builds. But |
This comment has been minimized.
This comment has been minimized.
Given that this is not possible - the vendor directory does not contain full modules, and people would object if it did - this seems like a likely decline. Leaving open for a week for final comments. |
This comment has been minimized.
This comment has been minimized.
No change in consensus so declining. |
I already have gopkg.in/yaml.v2 in my
vendor/
directory, managed withgo mod vendor
. However, when I rungo get github.com/tsg/gotpl
, this cache is ignored and the command fails due to how my particular network's proxies work.Can we please have
go get
... check for dependencies invendor/
, for more reproducible development environments and less network strain?