Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: build.golang.org failing to populate results for non-default repos with ?mode=json #35515

Closed
bcmills opened this issue Nov 11, 2019 · 3 comments
Assignees
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 11, 2019

I'm trying to adapt x/build/cmd/fetchlogs to produce useful results for repos other that the main go repo, fetching from URLs like https://build.golang.org/?repo=golang.org%2fx%2fcrypto&mode=json.

Unfortunately, with ?mode=json the results field seems to be full of empty strings for every revision:

{
			"repo": "go",
			"revision": "bd318be0434a57050ed475e0f45c3dbb16c09c2e",
			"parentRevisions": [
				"6e5058baadf9730b334298ee694a1784b617eb21"
			],
			"date": "2019-11-08T23:40:33Z",
			"branch": "master",
			"author": "Lars Lehtonen \u003clars.lehtonen@gmail.com\u003e",
			"desc": "pkcs12: fix dropped error\n\nThis fixes a dropped error in Decode().\n\nChange-Id: Iae5cac72f63a80dd5230034a3cfe1d6e76cc3415\nReviewed-on: https://go-review.googlesource.com/c/crypto/+/205421\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nRun-TryBot: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e",
			"results": [
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				"",
				""
			]
		}

CC @bradfitz @cagedmantis @toothrot @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Nov 11, 2019
@gopherbot gopherbot added the Builders label Nov 11, 2019
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 11, 2019

mode=json was added for use by the coordinator which only hits https://build.golang.org/?mode=json. I guess that combination of subrepo+json has just never been used/tested before.

@gopherbot
Copy link

@gopherbot gopherbot commented May 8, 2020

Change https://golang.org/cl/232897 mentions this issue: app/appengine: fix rendering of jsonView for subrepos

@findleyr findleyr self-assigned this May 8, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented May 8, 2020

Change https://golang.org/cl/232898 mentions this issue: cmd/fetchlogs: fetch repo data using the 'repo' query param

gopherbot pushed a commit to golang/build that referenced this issue May 18, 2020
The repo flag for fetchlogs is not currently that useful because it
queries the main Go dashboard data, which only has a few commits for
each subrepo. This was probably because the data at
  https://build.golang.org/?repo=<import path>&mode=json
was incorrect due to golang/go#35515.

With golang.org/cl/232897, this data should be corrected. Update
fetchlogs to now query data from the subrepo dashboard.

Change-Id: I352662abf7da6abb7bc23888b11e03927f567cab
Reviewed-on: https://go-review.googlesource.com/c/build/+/232898
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.