x/tools/gopls: inconsistent placement of new import with local

[zeebo]

Consider a module bug with package bug/bar that exports identifier X. gopls is configured to have the local option equal to "bug/". In the package bug, we have the source

package bug

import (
	"fmt"

	"golang.org/x/tools/blog"
)

var _ = fmt.Println

type _ = blog.Config

var _ = bar.X // user has just finished typing this

Issuing an Organize Imports action respects the local option and leaves the import block as

import (
	"fmt"

	"bug/bar"

	"golang.org/x/tools/blog"
)

whereas if the import for "bug/bar" is added through code complection, the import block will be

import (
	"fmt"
	"bug/bar"

	"golang.org/x/tools/blog"
)

which does not respect the local option.

[heschik]

source.addNamedImport almost certainly needs to read the "local" configuration and does not. Not sure why we need this vs. sharing code with source.computeImportEdits.

[gopherbot]

Change https://golang.org/cl/206881 mentions this issue: internal/lsp/source: unify import adding code

[heschik]

Er...I just realized I didn't actually test this exact case. But I'm pretty sure it's fixed. If not please comment.