Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: linux-mips* builders don't run on x/net and x/sys #35529

Closed
tklauser opened this issue Nov 12, 2019 · 4 comments
Closed

x/build: linux-mips* builders don't run on x/net and x/sys #35529

tklauser opened this issue Nov 12, 2019 · 4 comments
Labels
Builders FrozenDueToAge NeedsFix
Milestone
Unreleased

Comments

@tklauser
Copy link
Member

@tklauser tklauser commented Nov 12, 2019

https://build.golang.org/?repo=golang.org%2fx%2fnet#
https://build.golang.org/?repo=golang.org%2fx%2fsys#

No builds are shown for the linux-mips-rtrk, linux-mips64-rtrk, linux-mips64le-rtrk, linux-mipsle-rtrk and linux-mips64le-mengzhuo builders on master, even though the builders' corresponding policy should allow them:

https://github.com/golang/build/blob/773364d7ec5d1e0f2e7cd6698a7980beda1e577e/dashboard/builders.go#L2542-L2551

/cc @bradfitz @dmitshur @andybons
@gopherbot gopherbot added this to the Unreleased milestone Nov 12, 2019
@gopherbot gopherbot added the Builders label Nov 12, 2019
@tklauser
Copy link
Member Author

@tklauser tklauser commented Nov 12, 2019

#35515 related?

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 12, 2019

I suspect it's due to DisableSnapshot on those builders and coordinator not scheduling x repo work until a snapshot is available. Easy fix in coordinator.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 12, 2019

I don't think 35515 is related.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 12, 2019

Change https://golang.org/cl/206797 mentions this issue: cmd/coordinator: don't skip x/ work on SkipSnapshot builders

@andybons andybons added the NeedsFix label Nov 12, 2019
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@bradfitz @codebien
cmd/coordinator: don't skip x/ work on SkipSnapshot builders
4000e2b 
Fixes golang/go#35529

Change-Id: I61a08a1cff2428751e209412502d6dba1e11e36b
Reviewed-on: https://go-review.googlesource.com/c/build/+/206797
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders FrozenDueToAge NeedsFix
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @andybons @tklauser @gopherbot