Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/mod_load_badchain flake on windows-amd64-longtest #35539

Open
bcmills opened this issue Nov 12, 2019 · 0 comments
Assignees
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 12, 2019

2019-11-12T05:35:33-99957b6/windows-amd64-longtest

In CL 204777 I made the "finding versions" log message nondeterministic based on the actual delay of the operation. Perhaps it should be made deterministic — or at least made deterministic during testing — so that output during tests doesn't depend on the load factor of the test machine.

CC @jayconrod

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_load_badchain (15.88s)
        script_test.go:192: 
            # Download everything to avoid "finding" messages in stderr later. (7.343s)
        […]
            > cmp stderr list-missing-test-expected
            [diff -stderr +list-missing-test-expected]
            -go: finding versions for example.com
             go: found example.com/badchain/c in example.com/badchain/c v1.1.0
             go: m/testuse tested by
             	m/testuse.test imports
             	example.com/badchain/c: example.com/badchain/c@v1.1.0: parsing go.mod:
             	module declares its path as: badchain.example.com/c
             	        but was required as: example.com/badchain/c
            
            FAIL: testdata\script\mod_load_badchain.txt:35: stderr and list-missing-test-expected differ
            
FAIL
FAIL	cmd/go	376.850s
@bcmills bcmills added this to the Go1.14 milestone Nov 12, 2019
@bcmills bcmills self-assigned this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.