Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/unix: TestPselect flaky on some builders #35555

Closed
tklauser opened this issue Nov 13, 2019 · 3 comments
Closed

x/sys/unix: TestPselect flaky on some builders #35555

tklauser opened this issue Nov 13, 2019 · 3 comments
Milestone

Comments

@tklauser
Copy link
Member

@tklauser tklauser commented Nov 13, 2019

TestPselect occasionally fails with:

syscall_linux_test.go:301: Pselect: interrupted system call

linux-386: https://build.golang.org/log/d2ac4e02833b0129a9b11f5d3ea0f122d1813baf
linux-amd64-nocgo: https://build.golang.org/log/4f61e651ce23e678c12f88df80524ed7cd28c6e7
android-amd64-emu: https://build.golang.org/log/14519f68dd1a83e8868f110d3a31c6ceddf9f141

The easiest fix is probably to just skip TestPselect if Pselect returns EINTR.

/cc @ianlancetaylor @bradfitz

@gopherbot gopherbot added this to the Unreleased milestone Nov 13, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 13, 2019

Change https://golang.org/cl/206862 mentions this issue: unix: skip TestPselect on EINTR

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 16, 2019

Change https://golang.org/cl/207284 mentions this issue: unix: don't fail TestPselect on EINTR in zero Pselect case

gopherbot pushed a commit to golang/sys that referenced this issue Nov 18, 2019
Updates golang/go#35555

Change-Id: I3efb010c8edf92a75941c6b7ec749665235020d8
Reviewed-on: https://go-review.googlesource.com/c/sys/+/207284
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 18, 2019

Change https://golang.org/cl/207292 mentions this issue: unix: fix EINTR check in TestPselect

gopherbot pushed a commit to golang/sys that referenced this issue Nov 19, 2019
err == EINTR needs to be checked before err != nil for the interrupted
syscall to be retried properly.

Follow-up for CL 207284

Updates golang/go#35555

Change-Id: I76d569058b7985ec51f07909d86807a8b4911772
Reviewed-on: https://go-review.googlesource.com/c/sys/+/207292
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.