Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: move Internal types to internal package #35567

Open
bradfitz opened this issue Nov 13, 2019 · 3 comments
Open

testing: move Internal types to internal package #35567

bradfitz opened this issue Nov 13, 2019 · 3 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 13, 2019

InternalBenchmark, InternalExample, and InternalTest predate the "internal" package mechanism.

Per a discussion here, we could probably move those three into a new internal package, and add a type alias for a few cycles before removing the testing alias.

@bradfitz bradfitz added this to the Go1.15 milestone Nov 13, 2019
@andybons andybons modified the milestones: Go1.15, Backlog Nov 13, 2019
@rsc rsc added this to Incoming in Proposals Nov 27, 2019
@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2019

This seems like a likely accept given the reactions over the past two weeks.
/cc @mpvl

Leaving open for a week for final comments.

@rsc rsc changed the title testing: move Internal types to internal package proposal: testing: move Internal types to internal package Nov 27, 2019
@rsc rsc moved this from Incoming to Likely Accept in Proposals Dec 4, 2019
@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2019

No change in consensus, so accepting.

@rsc rsc changed the title proposal: testing: move Internal types to internal package testing: move Internal types to internal package Dec 4, 2019
@rsc rsc moved this from Likely Accept to Accepted in Proposals Dec 11, 2019
@tpaschalis
Copy link
Contributor

@tpaschalis tpaschalis commented May 29, 2020

Hey @bradfitz! Sorry for pinging, but I'd like to take a stab on this issue if that's okay with you!

From what I gather, we'd like move InternalBenchmark, InternalExample, and InternalTest into a new package most likely in src/internal/testing, or src/testing/internal.

Then, to avoid confusion during a couple of releases, we'd also like to alias them to their older names like type InternalBenchmark = internal.Benchmark.

I hope I'm not completely off the mark; please let me know if I've missed anything and I'll try to get a CL opened soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Proposals
Accepted
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.